Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: webpack 5.x #938

Merged
merged 8 commits into from
Oct 29, 2020
Merged

refactor: webpack 5.x #938

merged 8 commits into from
Oct 29, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Oct 29, 2020

unnamed

  • dependency bump where possible
    • refactor code to conform to latest standard
  • ipfs-http-client
  • ipfs (Brave broken again, let's stay on old version for now)
  • switch to webpack 5.x
    • re-introduce necessary polyfills as direct dependencies
    • disable unused codepaths (window.ipfs has been disabled for a while, no reason to compile and include related bundles)
    • confirm embedded js-ipfs works in Brave
    • confirm caching speeds up dev build (yes, ~40s → ~15s 🥳 )
  • switch to latest mocha
    • fix notifier bug in test suite
  • ensure CI is green ✔️

remove dependency just to be safer
mocha runs tests in node environment and this update clashed with some
bugs/edge cases around promises, thus this dependency bump includes
a small refactor (no functional changes)
@lidel lidel marked this pull request as ready for review October 29, 2020 20:25
@lidel lidel merged commit c900cc6 into master Oct 29, 2020
@lidel lidel deleted the chore/dep-bump-2020-10-27 branch October 29, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant