Skip to content

Commit

Permalink
fix: startup on Debian 10
Browse files Browse the repository at this point in the history
This disables sandboxing in ipfs-desktop.desktop manifest
which is ised by Desktop Environments for generating menus
and icons used for starting apps.

Rationale can be found at:
#1362 (comment)

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
  • Loading branch information
lidel committed Mar 10, 2020
1 parent b04f9dd commit 2ec7924
Show file tree
Hide file tree
Showing 4 changed files with 221 additions and 256 deletions.
26 changes: 26 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ IPFS Desktop allows you to run your IPFS Node on your machine without having to
- [Contribute](#contribute)
- [Translations](#translations)
- [FAQ](#faq)
- [Troubleshooting](#troubleshooting)

## Features

Expand Down Expand Up @@ -164,6 +165,31 @@ Since we're using [ipfsd-ctl](https://github.com/ipfs/js-ipfsd-ctl), we have our

By default we use the flags `--migrate=true --routing=dhtclient ----enable-gc=true` when running the IPFS daemon. They can be changed via the configuration file, which can be easily accessed as mentioned above.

## Troubleshooting

### Does not start on Linux (Debian 10)

Some Linux users may see an error like this:

> The SUID sandbox helper binary was found, but is not configured correctly.
Rather than run without sandboxing I'm aborting now. You need to make sure that
chrome-sandbox is owned by root and has mode 4755.

or a very short one, when starting in a terminal:

```console
$ ipfs-desktop
$Trace/breakpoint trap
```


**TL;DR** There are two ways of fixing this, pick one that works for you:

1. Change your kernel settings: `sudo sysctl kernel.unprivileged_userns_clone=1`
2. Disable the sandbox with commandline parameter: `ipfs-desktop --no-sandbox`

If you are interested in the history of Chrome sandboxing issues on Linux, read [this](https://github.com/ipfs-shipyard/ipfs-desktop/issues/1362#issuecomment-596857282).

## License

[MIT Protocol Labs, Inc.](./LICENSE)
2 changes: 2 additions & 0 deletions electron-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ nsis:
linux:
artifactName: ${name}-${version}-${os}-${arch}.${ext}
executableName: ipfs-desktop
executableArgs:
- --no-sandbox
icon: ipfs-desktop
category: Network;FileTransfer;P2P
synopsis: A desktop client for IPFS
Expand Down
Loading

0 comments on commit 2ec7924

Please sign in to comment.