chore: release-please uses GITHUB_TOKEN env var

ipfs · Oct 18, 2023 · f6cea9f · f6cea9f
1 parent 6820ffb
commit f6cea9f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -206,6 +206,8 @@ jobs:
       - name: Run release-please github-release # see https://github.com/google-github-actions/release-please-action/issues/841
         if: contains(github.ref, 'refs/tags/') && (github.event_name == 'push' || github.event_name == 'workflow_dispatch')
         run: npm run release-gh
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Build binaries with electron-builder
         uses: paneron/action-electron-builder@14b133702d1b2e9749912051c43ed62b4afe56c8 # v1.8.1
@@ -268,3 +270,5 @@ jobs:
 
       - name: Run release-please release-pr # see https://github.com/google-github-actions/release-please-action/issues/841
         run: npm run release-pr
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/DEVELOPER-NOTES.md b/DEVELOPER-NOTES.md
@@ -52,7 +52,7 @@ brew bump --open-pr homebrew/cask/ipfs
 
 ### Manual release process
 
-Be sure you have an environment variable `GH_TOKEN` set to a valid GitHub token with `repo` scope.
+Be sure you have an environment variable `GITHUB_TOKEN` set to a valid GitHub token with `repo` scope.
 
 ```bash
 ### Create release PR

diff --git a/package.json b/package.json
@@ -21,8 +21,8 @@
     "build:webui:download": "npx ipfs-or-gateway -c bafybeiamycmd52xvg6k3nzr6z3n33de6a2teyhquhj4kspdtnvetnkrfim -p assets/webui/ -t 360000 --verbose -g \"https://dweb.link\" ",
     "build:webui:minimize": "shx rm -rf assets/webui/static/js/*.map && shx rm -rf assets/webui/static/css/*.map",
     "package": "shx rm -rf dist/ && run-s build && electron-builder --publish onTag",
-    "release-pr": "release-please release-pr --token=$GH_TOKEN --plugin '@ipfs-shipyard/release-please-ipfs-plugin' --repo-url=ipfs/ipfs-desktop --trace --debug --draft-pull-request",
-    "release-gh": "release-please github-release --token=$GH_TOKEN --repo-url=ipfs/ipfs-desktop --trace --debug --draft"
+    "release-pr": "release-please release-pr --token=$GITHUB_TOKEN --plugin '@ipfs-shipyard/release-please-ipfs-plugin' --repo-url=ipfs/ipfs-desktop --trace --debug --draft-pull-request",
+    "release-gh": "release-please github-release --token=$GITHUB_TOKEN --repo-url=ipfs/ipfs-desktop --trace --debug --draft"
   },
   "pre-commit": [
     "lint"