Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable WebUI links in "IPFS is Not Running" state #1436

Closed
lidel opened this issue Apr 22, 2020 · 2 comments · Fixed by #1425
Closed

Disable WebUI links in "IPFS is Not Running" state #1436

lidel opened this issue Apr 22, 2020 · 2 comments · Fixed by #1425
Assignees
@hacdias
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P3 Low: Not priority right now topic/design-front-end Front-end implementation of UX/UI work

Comments

@lidel
Copy link
Member

lidel commented Apr 22, 2020

When node is stopped/offline, menu items that open WebUI are still active:

off-when-off-2020-04-23--00-49-45

Opening them shows webui in "unable to connect to node" state, which is bit confusing for less technical users.

I believe we should make them inactive when "IPFS is Not Running"
@lidel lidel added help wanted Seeking public contribution on this issue P3 Low: Not priority right now topic/design-front-end Front-end implementation of UX/UI work good first issue Good issue for new contributors exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours labels Apr 22, 2020
@jessicaschilling
Copy link
Contributor

+1.

@hacdias hacdias self-assigned this Apr 23, 2020
@hacdias
Copy link
Member

hacdias commented Apr 23, 2020 •
edited
Loading

Yes, I will make a PR asap. I think we have that that way because settings are in the web ui. I'll change that on #1425.

@hacdias hacdias mentioned this issue Apr 23, 2020
Merged
This was referenced Sep 16, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P3 Low: Not priority right now topic/design-front-end Front-end implementation of UX/UI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ux): move preferences to menubar ipfs/ipfs-desktop
3 participants
@lidel @jessicaschilling @hacdias