feat(ux): move preferences to menubar #1425

hacdias · 2020-04-18T16:10:21Z

This PR removes the Desktop settings from the Web UI panel! Related to #1389.

See feat: remove ipfs-desktop settings ipfs-webui#1445 merged
macOS guidelines prefer the term 'Preferences', others OSes users prefer 'Settings'
Adds the settings under 'Preferences' (macOS) or 'Settings' (others)
Some that might require more explanation get an information dialog before installing/enabling.
Errors are now more visible (user gets a dialog). Before, Web UI only said: "error while enabling X".
Closes Disable WebUI links in "IPFS is Not Running" state #1436 (disables web ui links when node is offline)

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

jessicaschilling

Nice 😊 Suggested some text tweaks and also one question. In your screenshot, it looks like both shortcuts are enabled, but the "Enable ..." menu items are still visible. Should they say "Disable ..." in that scenario? I'm a little unclear how the user disables these.

assets/locales/en.json

jessicaschilling · 2020-04-18T20:28:30Z

assets/locales/en.json

+ "ipfsOnPathInstall": {
+ "title": "Install IPFS on PATH",
+ "message": "By enabling this option, IPFS will be available on your command line as \"ipfs\". This action is reversible.",
+ "action": "Install"


For both the dialog boxes (and their menu items) related to IPFS on PATH, we're using "install/enable" and "uninstall/disable" interchangeably, which is a little confusing. Let's decide on either install/uninstall or enable/disable and be consistent throughout ... I might go for enable/disable so that it feels more like an option rather than something more severe, but there might be precedence for install/uninstall elsewhere that I'm unaware of?

Just updated everywhere to enable/disable that is not related to IPFS Desktop updates 😃

I might go for enable/disable so that it feels more like an option rather than something more severe

Agreed. We're not actually installing anything but when updating or enabling npm on IPFS, which I will make more clear.

assets/locales/en.json

hacdias · 2020-04-18T20:55:31Z

@jessicaschilling thanks for pointing that out. They’re actually not enabled. Those options enable them globally. They are checkboxes.

Now that I think of it, being a checkbox and having a verb (“Enable...”/“Disable...”) does not seem to be a great idea.

Either we keep the checkbox and remove the verb (simpler solution) or we toggle between verbs (Enable and Disable).

Checkbox tick example:

Here's an example of a mac app I use (Lungo) whose preferences are just checkboxes:

jessicaschilling · 2020-04-18T20:58:04Z

Checkboxes are good! If unchecked, do “take screenshot” and “disable hash” menu items act accordingly (do the shortcuts disappear)?

hacdias · 2020-04-18T21:13:02Z

Checkboxes are good! If unchecked, do “take screenshot” and “disable hash” menu items act accordingly (do the shortcuts disappear)?

The shortcuts always work if the menu is open. That’s why they’re visible. The preferences enable them globally, ie, even with the menu closer, you can press them and they’ll work. I guess we should find a better way to pass that message.

jessicaschilling · 2020-04-18T21:18:29Z

OH ... got it. Sorry! Good point though; I was confused, others will be too.

We don’t actually need “Enable” in menu items - the checkboxes imply it (see your Lungo example). Removing it would allow room for “Global Screenshot Shortcut” and “Global Download Shortcut”, which might be more explicit. Would like to run that past @lidel though.

hacdias · 2020-04-18T21:22:55Z

Yes, I agree we should wait for @lidel opinion on this 😃

hacdias · 2020-04-19T08:50:12Z

hacdias · 2020-04-20T08:31:37Z

Just as a thought: I wonder if some of the 'Advanced' things shouldn't be moved under Preferences. The only one that doesn't make much sense to me would be 'Run Garbage Collector'. All the others seem to fit under Preferences. Wdyt? (We can leave this to another PR if this one is good)

jessicaschilling · 2020-04-20T19:32:02Z

@hacdias - I'd be inclined to leave these under "Advanced" ... to a certain degree, they're sort of applicable to being considered preferences ... but only to advanced users. ;)

lidel

Labels look okay. Would keep "Advanced" as-is for now.
Small concern below tho.

lidel · 2020-04-21T01:02:40Z

assets/locales/en.json

@@ -16,7 +16,7 @@
 "readReleaseNotes": "Read Release Notes",
 "status": "Status",
 "files": "Files",
- "settings": "Settings",


Removing this from the top level menu may be a problem. I believe users will look for the "WebUI Settings" screen under "Settings" and won't find any entry point there.

Can we add it at the very top of new "Settings" submenu, to maintain continuity, of sorts?

One entry followed by a separator and then existing entries under "Desktop" header (similar to existing "Experiments"):

@jessicaschilling Does this make sense? If so, what would be the correct wording here: "Open Node Settings"? "Open WebUI Settings"?

Just rebased on top of master and added a "Open Node Settings" which opens Web UI settings:

This is great. Agree on “Node Settings” over “WebUI settings sine the thing you’re adjusting is the node itself.

How about adding Desktop Integrations header below the separator,
to make the grouping even more clear?

Just added:

Just wondering if it's really needed. But looks great

Having a clarification of “these are the prefs for this app” is a good idea. I might just say “App Preferences” though? Not sure if “desktop integrations” makes sense unless you’re already deeply familiar.

@lidel what do you think?

hacdias · 2020-04-22T07:10:02Z

@lidel other than the the 'Desktop Integrations' label, is there anything you'd change?

hacdias · 2020-04-22T09:11:41Z

Just renamed 'Desktop Integrations' to 'App Preferences'

jessicaschilling · 2020-04-22T15:25:31Z

LGTM, but let's get @lidel's blessing first 😊

hacdias · 2020-04-22T22:17:15Z

Yes!

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias · 2020-04-23T07:11:32Z

@lidel I decided to fix #1436 because those links enable the user to access IPFS Desktop settings unless this one gets merged.

lidel

LGTM, thanks! (no strong feeling about labels, just wanted to have the option in menu 👍)
Feel free to merge if nothing else is needed here.

* chore: remove old event handler removed in #1425 * refactor: use ipcMainEvents constant

hacdias force-pushed the feat/preferences branch from 816117d to 229dac8 Compare April 18, 2020 17:44

hacdias requested review from lidel and jessicaschilling and removed request for lidel April 18, 2020 17:46

hacdias marked this pull request as ready for review April 18, 2020 17:46

hacdias mentioned this pull request Apr 18, 2020

Release 0.11.0 #1415

Closed

22 tasks

hacdias changed the title ~~feat: add preferences to menubar~~ feat(ux): move preferences to menubar Apr 18, 2020

jessicaschilling reviewed Apr 18, 2020

View reviewed changes

hacdias force-pushed the feat/preferences branch 5 times, most recently from 1ca47ca to 869c28c Compare April 19, 2020 09:26

hacdias mentioned this pull request Apr 20, 2020

feat(ux): open Web UI at launch on Linux #1429

Merged

lidel reviewed Apr 21, 2020

View reviewed changes

hacdias force-pushed the feat/preferences branch from 869c28c to 69a1f6c Compare April 21, 2020 07:31

hacdias mentioned this pull request Apr 21, 2020

feat: remove ipfs-desktop settings ipfs/ipfs-webui#1445

Merged

hacdias force-pushed the feat/preferences branch from bb8a92c to f66bd70 Compare April 22, 2020 07:08

hacdias force-pushed the feat/preferences branch from f66bd70 to c704288 Compare April 22, 2020 07:57

jessicaschilling approved these changes Apr 22, 2020

View reviewed changes

hacdias requested a review from lidel April 23, 2020 07:01

hacdias mentioned this pull request Apr 23, 2020

Disable WebUI links in "IPFS is Not Running" state #1436

Closed

hacdias added 3 commits April 23, 2020 08:07

feat(ux): move preferences to menubar

cb201e9

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

rename desktop integrations to app preferences

ad91dce

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

feat: disable web ui links when node is not online

1d289a9

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

hacdias force-pushed the feat/preferences branch from daa6fac to 1d289a9 Compare April 23, 2020 07:09

fix: disable web ui node settings too

342db0a

License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>

lidel approved these changes Apr 24, 2020

View reviewed changes

hacdias merged commit dfad823 into master Apr 24, 2020

hacdias deleted the feat/preferences branch April 24, 2020 07:01

lidel mentioned this pull request Apr 27, 2020

WIP: Feat/backend toggle switch for desktop settings ipfs/ipfs-webui#895

Closed

hacdias added a commit that referenced this pull request Sep 1, 2022

chore: remove old event handler removed in #1425

6f596d5

hacdias mentioned this pull request Sep 26, 2022

refactor: use ipcMainEvents constant #2250

Merged

SgtPooki pushed a commit that referenced this pull request Oct 3, 2022

refactor: use ipcMainEvents constant (#2250)

39754b9

* chore: remove old event handler removed in #1425 * refactor: use ipcMainEvents constant

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ux): move preferences to menubar #1425

feat(ux): move preferences to menubar #1425

hacdias commented Apr 18, 2020 •

edited

Loading

jessicaschilling left a comment

jessicaschilling Apr 18, 2020

hacdias Apr 19, 2020

hacdias commented Apr 18, 2020 •

edited

Loading

jessicaschilling commented Apr 18, 2020

hacdias commented Apr 18, 2020

jessicaschilling commented Apr 18, 2020

hacdias commented Apr 18, 2020

hacdias commented Apr 19, 2020

hacdias commented Apr 20, 2020

jessicaschilling commented Apr 20, 2020

lidel left a comment •

edited

Loading

lidel Apr 21, 2020 •

edited

Loading

hacdias Apr 21, 2020

jessicaschilling Apr 21, 2020

lidel Apr 21, 2020 •

edited

Loading

hacdias Apr 21, 2020

jessicaschilling Apr 21, 2020

hacdias Apr 22, 2020

hacdias commented Apr 22, 2020

hacdias commented Apr 22, 2020

jessicaschilling commented Apr 22, 2020

hacdias commented Apr 22, 2020

hacdias commented Apr 23, 2020

lidel left a comment

feat(ux): move preferences to menubar #1425

feat(ux): move preferences to menubar #1425

Conversation

hacdias commented Apr 18, 2020 • edited Loading

jessicaschilling left a comment

Choose a reason for hiding this comment

jessicaschilling Apr 18, 2020

Choose a reason for hiding this comment

hacdias Apr 19, 2020

Choose a reason for hiding this comment

hacdias commented Apr 18, 2020 • edited Loading

jessicaschilling commented Apr 18, 2020

hacdias commented Apr 18, 2020

jessicaschilling commented Apr 18, 2020

hacdias commented Apr 18, 2020

hacdias commented Apr 19, 2020

hacdias commented Apr 20, 2020

jessicaschilling commented Apr 20, 2020

lidel left a comment • edited Loading

Choose a reason for hiding this comment

lidel Apr 21, 2020 • edited Loading

Choose a reason for hiding this comment

hacdias Apr 21, 2020

Choose a reason for hiding this comment

jessicaschilling Apr 21, 2020

Choose a reason for hiding this comment

lidel Apr 21, 2020 • edited Loading

Choose a reason for hiding this comment

hacdias Apr 21, 2020

Choose a reason for hiding this comment

jessicaschilling Apr 21, 2020

Choose a reason for hiding this comment

hacdias Apr 22, 2020

Choose a reason for hiding this comment

hacdias commented Apr 22, 2020

hacdias commented Apr 22, 2020

jessicaschilling commented Apr 22, 2020

hacdias commented Apr 22, 2020

hacdias commented Apr 23, 2020

lidel left a comment

Choose a reason for hiding this comment

hacdias commented Apr 18, 2020 •

edited

Loading

hacdias commented Apr 18, 2020 •

edited

Loading

lidel left a comment •

edited

Loading

lidel Apr 21, 2020 •

edited

Loading

lidel Apr 21, 2020 •

edited

Loading