Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.11.0 #1415

Closed
16 of 22 tasks
hacdias opened this issue Apr 17, 2020 · 22 comments · Fixed by #1467
Closed
16 of 22 tasks

Release 0.11.0 #1415

hacdias opened this issue Apr 17, 2020 · 22 comments · Fixed by #1467

Comments

@hacdias
Copy link
Member

hacdias commented Apr 17, 2020 •
edited by lidel
Loading

Release Notes

🚨 Breaking Changes

✨ Features

🛠 Fixes and Maintenance

Before Release

  • Make sure i18n is updated (tx pull -a)
  • Make sure we're using the latest released version of Web UI
  • Make sure we're using the latest released version of go-ipfs
  • Update Release Notes accordingly

Release

  • Release Candidate
    • 💻 Bump version on package.json
    • 💻 git tag $version
    • 💻 git push && git push --tags
    • ⏰ Wait...
    • 🔗 Link release notes to this issue
  • Final
    • 📝 Create draft and copy the release notes above
    • 💻 Bump version on package.json
    • 💻 git tag $version
    • 💻 git push && git push --tags
    • ⏰ Wait...
    • 📃 Copy the release notes above to the GitHub release
    • 👮 Notarize .dmg at Apple (context: #1365)
      1. Download .dmg from https://github.com/ipfs-shipyard/ipfs-desktop/releases/vA.B.C
      2. Ensure APPLEID and APPLEIDPASS are set either as environment variables or entries in .env file. Those need to belong to the same org as cert used for signing.
      3. Run node pkgs/macos/notarize-cli.js ./IPFS-Desktop-A.B.C.dmg
    • 🚢 Ship!
    • 📑 Update README.md versions
    • 📦 Update Homebrew
    • 📦 Update Chocolatey

Postponed

If any...
@hacdias hacdias pinned this issue Apr 17, 2020
@lidel
Copy link
Member

lidel commented Apr 17, 2020 •
edited
Loading

Note: update to electron 8 broke tray icon on verious Linux setups, making it impossible to start/stop the node, nor open webui – see #1153 (comment)

Releasing this would introduce regression for existing users.
We need to either revert that update, or figure out a way of solving the Linux problem.

@lidel lidel added the status/blocked Unable to be worked further until needs are met label Apr 17, 2020
@hacdias
Copy link
Member Author

hacdias commented Apr 17, 2020

Hmm. You’re right. Honestly I doubt Electron/Chromium folks are going to fix this soon. It’s been years talking about Linux and its Tray icons and nothing has been done.

One one hand, I don’t want to prevent Linux users to have access to IPFS desktop. On the other hand, I don’t want to keep using an old version of Electron ad infinitum when there are no assurances that this will be fixed.

I’ll revert this for now (will do tomorrow) but we need to find a solution.

@lidel
Copy link
Member

lidel commented Apr 17, 2020

I agree, but I don't believe we should revert this: getting the latest Electron fixes are probably more important than keeping legacy tray support on Linux.

We just need to have UX workaround in place for Linux before 0.11 ships (show webui when ipfs-desktop is called while it is already running, or could be a custom popup, could be extensive "Tray on Linux" section in README etc – need to think about)

@hacdias
Copy link
Member Author

hacdias commented Apr 18, 2020

Okay, let's find out a way!

@momack2
Copy link

momack2 commented Apr 26, 2020

Hey Folks! Flagging this for the go-ipfs 0.5 release train. go-ipfs RC-4 (ipfs/kubo#7109 (comment)) has the final changes prior to release next week. We'd like the network to update ASAP to 0.5 so that everyone can experience the performance improvements. If this desktop release is currently blocked on the Linux issues mentioned above, can we cut an intermediary release which will help upgrade desktop users to 0.5.0 next week?

@momack2
Copy link

momack2 commented Apr 26, 2020 •
edited
Loading

Should there be anything in these release steps about MacOS notarization too? (#1365 (comment))

@hacdias
Copy link
Member Author

hacdias commented Apr 27, 2020 •
edited
Loading

@momack2 #1429 should unblock this. Just waiting for review! 😄

The notarization thingy was released/fixed with v0.10.4.

@lidel
Copy link
Member

lidel commented Apr 27, 2020

Notarization is still a manual step that needs to happen before publishing release draft on github. I added it to the checklist before "Ship" step, to ensure we don't forget.

@lidel lidel removed the status/blocked Unable to be worked further until needs are met label Apr 27, 2020
@lidel
Copy link
Member

lidel commented Apr 27, 2020 •
edited
Loading

Ok, I believe we reviewed and merged key PRs (Linux is unblocked by #1429) and figured out notarization plan. More or less just waiting for 0.5 to land.

Things that need to happen before release:

@lidel
Copy link
Member

lidel commented Apr 28, 2020 •
edited
Loading

We switched to ipfs-webui 2.8.0 and drag&drop issues should be gone.

@rafaelramalho19 is taking a look at the remaining problem with adding folders via button (drag&drop works: #1287 (comment)).

Would be nice to include a fix for that in this release, but if the fix takes longer we can always ship it later as a patch release (it was already broken in ipfs-desktop v0.10.4 too, so no regression for existign users) – priority here is switching desktop users to go-ipfs 0.5.

@bertrandfalguiere
Copy link
Contributor

bertrandfalguiere commented Apr 28, 2020 •
edited
Loading

I'm currently correcting translations in French for IPFS Desktop and the Web UI, if you can afford to wait 1h.

@bertrandfalguiere
Copy link
Contributor

Done. You may want to reimport translations for Web UI, Desktop, Share files, Companion and IPLD explorer.

@lidel
Copy link
Member

lidel commented Apr 28, 2020 •
edited
Loading

Thank you @bertrandfalguiere!

@jessicaschilling @rafaelramalho19
I checked in with go-ipfs team and we are prioritizing shipping go-ipfs 0.5 to users, so we will cut 0.11.0 today with Desktop translation updates and go-ipfs 0.5 and later this week ship a patch release of Desktop (0.11.1) with fix for #1287 (comment) and any missed translation updates in webui.

@lidel lidel mentioned this issue Apr 28, 2020
Merged
@lidel
Copy link
Member

lidel commented Apr 28, 2020

(tagged and built v0.11.0, waiting for macOS notarization before publishing release)

@lidel
Copy link
Member

lidel commented Apr 28, 2020

Applied two hotfixes, recreating release:

@lidel
Copy link
Member

lidel commented Apr 28, 2020 •
edited
Loading

@NatoBoram
Copy link

Can the Linux & Windows binaries be published before the ones for MacOS?

@bertrandfalguiere
Copy link
Contributor

Thank you @bertrandfalguiere!

@jessicaschilling @rafaelramalho19
I checked in with go-ipfs team and we are prioritizing shipping go-ipfs 0.5 to users, so we will cut 0.11.0 today with Desktop translation updates and go-ipfs 0.5 and later this week ship a patch release of Desktop (0.11.1) with fix for #1287 (comment) and any missed translation updates in webui.

Apparently, traductions from ipld-explorer-components should be pulled and bubbled too, according to: ipfs/ipfs-webui#1477 (comment)
:)

@lidel
Copy link
Member

lidel commented Apr 29, 2020 •
edited
Loading

@NatoBoram sadly the current setup (based on https://www.electron.build/auto-update.html) is all-or-nothing: we are unable to publish a release to the official channel without impacting Mac users.

That being said, if you want to help us testing v0.11.0 on Linux,
here are binaries that are waiting for publishing:
bafybeiegs4nplthqhneuhsm6n7qwczswf7yjr77yeimwbvkpi5mmewdrxm

Let us know if anything looks odd, note the Tray issues on Linux (#1153 / #1466)

@lidel lidel mentioned this issue Apr 29, 2020
Merged
@bertrandfalguiere
Copy link
Contributor

@NatoBoram The Linux version was published a few hours ago on snap (now the default on Ubuntu 20.04).

@lidel is the realese on snap an independant/parallel process of/to realeases elsewhere?

@lidel
Copy link
Member

lidel commented Apr 29, 2020 •
edited
Loading

@bertrandfalguiere it is a single build pipeline, but since #1157 snap is published to snapstore instead of being attached to a draft of a github release.

@lidel
Copy link
Member

lidel commented Apr 29, 2020

Shipped: v0.11.1 🚢

@lidel lidel unpinned this issue Apr 29, 2020
@bertrandfalguiere bertrandfalguiere mentioned this issue Apr 29, 2020
Merged
@bertrandfalguiere bertrandfalguiere mentioned this issue May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: v0.11.1 release links in README ipfs/ipfs-desktop
5 participants
@lidel @momack2 @hacdias @bertrandfalguiere @NatoBoram