feat(ux): improve gc

[hacdias]

As @RubenKelevra noted, GC might take a while to finish running. So I took their suggestions and implemented them (see bellow).

This PR:

• Improves UX while GC is running;
• Adds a custom error message when GC fails;
• Cleans up tray logic a bit.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

[RubenKelevra]

It's neat for blocking this option, but we should show it more prominently.

How about changing the green dot to a yellow broom, and instead of "IPFS is running" change the message to "IPFS is running the garbage collector" or something like this? 🤔

I think the ususally degraded performance justifies that the icon should be yellow instead of green.

[hacdias]

@RubenKelevra that's definitely a good idea! Let me see what I can do. I actually wanted to clean up tray logic. Might be an opportunity to improve it a bit.

[hacdias]

GC not running:

GC running:

Edit: I renamed GC to Garbage Collector.

[RubenKelevra]

Well, I would still vote for a broom instead of just 'yellow' which looks like something is partly broken 🤔

But the rest looks very nice!

[hacdias]

Ahah I like the Broom idea but we'd need to add that icon at some specific sizes and I think it's easier for now to keep the yellow circle. 🧹🧹

[RubenKelevra]

Ahah I like the Broom idea but we'd need to add that icon at some specific sizes and I think it's easier for now to keep the yellow circle.

Here you go:

https://commons.wikimedia.org/wiki/File:Artworkbean_broom.svg

[hacdias]

Thanks! Let's see what @lidel and @jessicaschilling have to say and save the icon for a next iteration. Let's not forget that the icon will be displayed in a very small size so it can't be too detailed.

[jessicaschilling]

This is cool! I’m a little concerned that users will think IPFS isn’t running when GC is running. There isn’t a great option for text due to space but maybe “Running with Garbage Collection”? And I’d gray out the stop and restart items rather than remove them entirely, to indicate you can still stop and restart, just not right now.

An aside: We should capitalize “IPFS is Running” to match the other menu items.

Regarding broom - it’s going to be really tough to make that legible at small sizes, unfortunately. We’re also working on some stuff in ipfs-css that’s nearly finished, so suggest leaving that out for the time being.

[jessicaschilling]

See my thoughts earlier 😊

[hacdias]

I’m a little concerned that users will think IPFS isn’t running when GC is running. There isn’t a great option for text due to space but maybe “Running with Garbage Collection”?

What if we explain in the dialog before? I'm concerned about such a long sentence because it would seem all the other options are really small compared to that one.

An aside: We should capitalize “IPFS is Running” to match the other menu items.

Will do!

Regarding broom - it’s going to be really tough to make that legible at small sizes, unfortunately.

👍

[jessicaschilling]

“Running (Garbage Collecting)”?
If it takes a long time, they might forget about the dialog 😉

[hacdias]

Like this? Seems a bit displaced 😢

[jessicaschilling]

I see what you mean, but I do think it’s better than being unclear. Plus it’s not a super-frequent scenario. Let’s see what @lidel says.

[hacdias]

Yeah, I agree. Let's wait for lidel input!

[lidel]

LGTM (small typo below).
Logic in updateMenu is slowly getting messy, but tolerable for now.

@hacdias remember to merge this before #1411 (and #1411 should be rebased on top of this)

[RubenKelevra]

Regarding broom - it’s going to be really tough to make that legible at small sizes, unfortunately.
Maybe doing a small animation would help?

Here's some inspiration :)