Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repo fsck is deprecated #1438

Merged
merged 1 commit into from
Apr 27, 2020
Merged

fix: repo fsck is deprecated #1438

merged 1 commit into from
Apr 27, 2020

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Apr 23, 2020

ipfs repo fsck seems to have been deprecated (ipfs/kubo@288a83c) in the meanwhile so our logic wasn't working.

I changed it so now we manually check if it's a connection refused error. If so, check if there's a config file. If so, remove the api file.

If no config file, then it's a remote api connection, show error to the user.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

@hacdias hacdias added kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up labels Apr 23, 2020
@hacdias hacdias requested a review from lidel April 23, 2020 09:14
@hacdias hacdias added P0 Critical: Tackled by core team ASAP and removed P1 High: Likely tackled by core team if no one steps up labels Apr 23, 2020
@hacdias hacdias mentioned this pull request Apr 23, 2020
22 tasks
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented Apr 27, 2020

I'm merging this for now since I'm stumble on this error every now and then and it's annoying. It's also a simple PR. We can change anything on another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant