Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notify when the update is available #1384

Merged
merged 1 commit into from
Apr 4, 2020
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 26, 2020

Adds a notification when the user clicks 'Check for Updates...' and there is an update available. Right now, we either show the notification when there is no update available or we finished downloading the update, which may take some time.

Not sure if this addresses #1378 but I'm pretty sure it will improve UX anyways.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias requested review from autonome and lidel March 26, 2020 15:49
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this does not address #1378, it improves UX by letting user know the download is happening.

@lidel lidel merged commit f7891f3 into master Apr 4, 2020
@lidel lidel deleted the notify-update-available branch April 4, 2020 22:24
@hacdias hacdias mentioned this pull request Apr 17, 2020
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants