Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drag n drop now works if outside the file area #1468

Merged
merged 2 commits into from
Apr 27, 2020
Merged

fix: drag n drop now works if outside the file area #1468

merged 2 commits into from
Apr 27, 2020

Conversation

rafaelramalho19
Copy link
Contributor

Possible fix for #1367

Notes

  • Drag n dropping outside the "files" area would result in the error reported in the issue. However, drag n dropping in the "files" would work just fine with the same file. After some investigation, the root property appears to be undefined when dragging outside the zone 🤷

lidel
lidel approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm, this fixes drag&drop issues with folders in Firefox and Chrome (listed in ipfs/ipfs-desktop#1287 (comment)), let's merge this ASAP.

@lidel lidel merged commit 2a4f920 into ipfs:master Apr 27, 2020
This was referenced Apr 27, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelramalho19 @lidel