Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPLD explorer category not available in transifex #1477

Closed
Luflosi opened this issue Apr 28, 2020 · 3 comments · Fixed by #1515
Closed

IPLD explorer category not available in transifex #1477

Luflosi opened this issue Apr 28, 2020 · 3 comments · Fixed by #1515
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@Luflosi
Copy link
Contributor

Luflosi commented Apr 28, 2020

Describe the bug
I noticed, that https://github.com/ipfs-shipyard/ipfs-webui/tree/master/public/locales/de contains six files (explore.json, files.json, peers.json, settings.json, status.json and welcome.json) but explore-json is missing from transifex, at least for the german translation:
screenshot
When I search for any string in explore.json I also can't find it on transifex.
Am I doing something wrong?

@Luflosi Luflosi added the need/triage Needs initial labeling and prioritization label Apr 28, 2020
@bertrandfalguiere
Copy link
Contributor

Same problem in French: file is missing from Transifex

@jessicaschilling jessicaschilling added exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Apr 28, 2020
@jessicaschilling
Copy link
Contributor

Thanks, @bertrandfalguiere and @Luflosi, for spotting this! We're all a bit all-hands-on-deck today with the most recent go-ipfs release, but rest assured we'll look ASAP.

@lidel lidel added exp/novice Someone with a little familiarity can pick up kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up and removed effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers P0 Critical: Tackled by core team ASAP labels Apr 28, 2020
@lidel
Copy link
Member

lidel commented Apr 28, 2020

Thank you for bringing this to our attention: this is a sideffect of current design.

The IPLD Explorer is both a subscreen in ipfs-webui but also a standalone web app at https://explore.ipld.io/ – the repo for https://explore.ipld.io website is ipld-explorer

Both ipfs-webui and ipld-explorer website depend on shared components from ipld-explorer-components, and that is where translations of IPLD Explorer live. They are exposed on Transifex under https://www.transifex.com/ipfs/ipld-explorer/ and you can translate strings there.

The problem here is that we did not had bandwidth to bubble up new ipld-explorer-components (with updated translations) to ipfs-webui yet. But don't worry, we will :)

cc @rafaelramalho19 – we should do this before we make next release, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants