feat: add "Help Translation" under "About" #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
changed the title
assets/locales/en.json
Outdated
| @@ -13,7 +13,8 @@ | |||
| "openRepoDir": "Open Repository Directory", | |||
| "openLogsDir": "Open Logs Directory", | |||
| "openConfigFile": "Open Configuration File", | |||
| "viewOnGitHub": "View on GitHub", | |||
| "viewOnGitHub": "View on GitHub…", | |||
| "helpUsTranslate": "Help Translating…", | |||
There was a problem hiding this comment.
“Help Translate This App...”?
I understand it’s going to expand the menu width, but it’s the shortest phrase I can find that makes it clear we are talking about human languages rather than programming languages.
Another option might be “IPFS Translation Project...”, but it doesn’t have a verb in there, which makes it inconsistent with other menu items.
There was a problem hiding this comment.
Uh, I prefer "Help Translate This App" on this case.
There was a problem hiding this comment.
I don't think it looks bad:
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds "Help Translating" to the menubar "About" section and replaces all "..." by the ellipsis character "…". The link opens transifex.
This partially addresses #844. The dialog will come on a different PR.