Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved update experience #1414

Merged
merged 7 commits into from
Apr 17, 2020
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Apr 17, 2020

This improves the experience while updating. Here are two dialog screenshots and please review the code for more copy.

Screenshot 2020-04-17 at 17 35 35

Screenshot 2020-04-17 at 17 35 54

Note: Electron's logo is replaced by IPFS Desktop's in production.

User Journey

  • User clicked 'Check for Updates'
    • If available, receives dialog (with close and read release notes buttons).
    • If not available, receives dialog (with close and read release notes buttons).
    • If error, receives dialog telling to check the Internet connection.
    • Update downloaded, receives dialog with button to restart IPFS Desktop.
  • Auto updater found an update (every 12 hours)
    • If available, nothing, downloads in background.
    • If not available, nothing happens.
    • If error, gets logged internally.
    • Update downloaded, receives a notification they can click to install the update.

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias mentioned this pull request Apr 17, 2020
22 tasks
@jessicaschilling
Copy link
Contributor

jessicaschilling commented Apr 17, 2020

@hacdias

If not available, receives dialog (with close and read release notes buttons).

Do we really need the release notes if the message is "you're already on the latest version"?

Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny language tweaks plus one question - thanks!

assets/locales/en.json Outdated Show resolved Hide resolved
assets/locales/en.json Outdated Show resolved Hide resolved
assets/locales/en.json Outdated Show resolved Hide resolved
assets/locales/en.json Outdated Show resolved Hide resolved
hacdias and others added 4 commits April 17, 2020 19:23
Co-Authored-By: Jessica Schilling <jessica@protocol.ai>
Co-Authored-By: Jessica Schilling <jessica@protocol.ai>
Co-Authored-By: Jessica Schilling <jessica@protocol.ai>
Co-Authored-By: Jessica Schilling <jessica@protocol.ai>
@hacdias
Copy link
Member Author

hacdias commented Apr 17, 2020

Do we really need the release notes if the message is "you're already on the latest version"?

Probably not, will remove.

Tiny language tweaks plus one question - thanks!

Thank you!

License: MIT
Signed-oaff-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented Apr 17, 2020

@jessicaschilling removed!

@hacdias hacdias merged commit 52312f4 into master Apr 17, 2020
@hacdias hacdias deleted the feat/improved-update-experience branch April 17, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Check for Updates.." menu item gives no feedback
2 participants