Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open app window with double-click on tray icon #1764

Closed
AbakumovAlexandr opened this issue Feb 20, 2021 · 7 comments · Fixed by #1766
Closed

Open app window with double-click on tray icon #1764

AbakumovAlexandr opened this issue Feb 20, 2021 · 7 comments · Fixed by #1766
Assignees
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers P3 Low: Not priority right now

Comments

@AbakumovAlexandr
Copy link

Usually, single or double-click on a tray icon opens the main app window.

Describe alternatives you've considered
With IPFS Desktop to open the app window, we have to open a tray icon menu and click on a certain item.

Can we have the same behavior in IPFS Desktop: when double-clicking on the tray icon - open the app window on the last 'activity' for faster access to the app via the tray icon?

@AbakumovAlexandr AbakumovAlexandr added the need/triage Needs initial labeling and prioritization label Feb 20, 2021
@ipfs ipfs deleted a comment from welcome bot Feb 23, 2021
@lidel lidel added exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue P3 Low: Not priority right now labels Feb 23, 2021
@lidel
Copy link
Member

lidel commented Feb 23, 2021

The behavior depends on platform. Some patters are only valid on Windows or Linux, but not macOS.
@AbakumovAlexandr which platform you have in mind?

Either way, if you or someone else wants to adjust behavior on specific platform, PRs welcome!
Code responsible for tray is in src/tray.js. Make sure to familiarize yourself with platform-specific limitations listed on https://www.electronjs.org/docs/api/tray

@lidel lidel added good first issue Good issue for new contributors and removed need/triage Needs initial labeling and prioritization good first issue Good issue for new contributors help wanted Seeking public contribution on this issue labels Feb 23, 2021
@lidel
Copy link
Member

lidel commented Feb 23, 2021

Actually, this may be easy to clean up as part of #1762.
I'll look into this.

@lidel lidel self-assigned this Feb 23, 2021
@lidel lidel mentioned this issue Feb 23, 2021
2 tasks
@AbakumovAlexandr
Copy link
Author

platform

I'm talking about Windows. Thank you!

@lidel
Copy link
Member

lidel commented Feb 24, 2021

@AbakumovAlexandr please update to 0.14.0 and let us know if the double-click behavior is correct.

@AbakumovAlexandr
Copy link
Author

@lidel Thank you double click is working!

However, for me there are still 2 minor issues:

  1. Double click always opens the app on the STATUS screen. It would be great if it would open it on the last screen I was on before closing the window.

  2. Single click with left mouse button still opens the context menu even when doing double click. So, the first left click quickly opens the menu until the second left click is done. Usually Windows apps are designed so that if tray icon menu opens with the right click, it just ignores the single left click.

@lidel
Copy link
Member

lidel commented Feb 25, 2021

@AbakumovAlexandr Thanks! Do you mind filling those as two new issues? 🙏

@AbakumovAlexandr
Copy link
Author

@lidel Sure, I'm happy to do so. Please see ##1771 and ##1772.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers P3 Low: Not priority right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants