Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.14.0-rc1 it fails to start on Windows 10 #1762

Closed
lidel opened this issue Feb 19, 2021 · 0 comments · Fixed by #1766
Closed

0.14.0-rc1 it fails to start on Windows 10 #1762

lidel opened this issue Feb 19, 2021 · 0 comments · Fixed by #1766
Assignees
@lidel
Labels
area/windows Windows kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding P0 Critical: Tackled by core team ASAP

Comments

@lidel
Copy link
Member

lidel commented Feb 19, 2021 •
edited
Loading

@mvdan reported 0.14.0-rc1 it fails to start on Windows 10:

the icon shows up and turns green, but when I click on it, it shows the "something went wrong" dialog.
clicking the "report bug" shows this error string on the github template:

TypeError: event.preventDefault is not a function
    at Object.<anonymous> (C:\Users\user\AppData\Local\Programs\IPFS Desktop\resources\app.asar\src\tray.js:269:13)
    at Object.emit (events.js:315:20)
@lidel lidel added kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP area/windows Windows need/analysis Needs further analysis before proceeding labels Feb 19, 2021
@lidel lidel self-assigned this Feb 19, 2021
@lidel lidel mentioned this issue Feb 23, 2021
Closed
lidel added a commit that referenced this issue Feb 23, 2021
@lidel
refactor: tray click events
c606829 
- avoid `TypeError: event.preventDefault is not a function`
  (closes #1762)
- double-click opens webui (closes #17649

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel mentioned this issue Feb 23, 2021
Merged
2 tasks
lidel added a commit that referenced this issue Feb 23, 2021
@lidel
refactor: tray click events (#1766)
1e00334 
- avoid random `TypeError: event.preventDefault is not a function`  (closes #1762)
- double-click opens webui (closes #17649)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
area/windows Windows kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: tray click events ipfs/ipfs-desktop
1 participant
@lidel