Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: All ipcMain.emit eventNames should be standardized and typed #2115

Closed
SgtPooki opened this issue Apr 28, 2022 · 1 comment · Fixed by #2250
Closed

chore: All ipcMain.emit eventNames should be standardized and typed #2115

SgtPooki opened this issue Apr 28, 2022 · 1 comment · Fixed by #2250
Assignees
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature kind/maintenance Work required to avoid breaking changes or harm to project's status quo P3 Low: Not priority right now status/ready Ready to be worked

Comments

@SgtPooki
Copy link
Member

ipcMain.emit('updating')

ipcMain.emit('updatingEnded')

ipcMain.emit('ipfsConfigChanged') // trigger node restart

ipcMain.emit('gcRunning')

ipcMain.emit('gcEnded')

ipcMain.emit('languageUpdated', lang)

ipcMain.emit('ipfsd', status, id)

click: () => { ipcMain.emit(`toggle_${key}`) },

menu.on('menu-will-show', () => { ipcMain.emit('menubar-will-open') })

menu.on('menu-will-close', () => { ipcMain.emit('menubar-will-close') })

ipcMain.emit('configUpdated')

ipcMain.emit('ipfsConfigChanged') // trigger node restart

ipcMain.emit('ipfsConfigChanged') // trigger node restart

generated with:

git fetch --all
git checkout main
git pull
# then...
rg 'ipcMain.emit' src -n -m 999 --no-heading | awk '{print "https://github.com/ipfs/ipfs-desktop/blob/COMMIT_HASH/" $1}' | sed 's/:$//g' | gsed -e 's/:\([0-9]\+\)/#L\1/' -e "s/COMMIT_HASH/$(cat .git/refs/heads/main)/"
@SgtPooki SgtPooki added need/triage Needs initial labeling and prioritization kind/maintenance Work required to avoid breaking changes or harm to project's status quo labels Apr 29, 2022
@SgtPooki SgtPooki added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now kind/enhancement A net-new feature or improvement to an existing feature good first issue Good issue for new contributors effort/hours Estimated to take one or several hours status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels May 16, 2022
@noliveira95
Copy link
Contributor

#2189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature kind/maintenance Work required to avoid breaking changes or harm to project's status quo P3 Low: Not priority right now status/ready Ready to be worked
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants