Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create enum for ipcMain eventNames #2189

Merged
merged 7 commits into from
Jul 20, 2022
Merged

Conversation

noliveira95
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Jun 25, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Contributor Author

@noliveira95 noliveira95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: change destructured to added curly brackets for callback

@hacdias hacdias requested a review from SgtPooki July 1, 2022 14:19
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single update requested! Thanks so much for this =D

src/utils/create-toggler.js Outdated Show resolved Hide resolved
@SgtPooki SgtPooki requested a review from lidel July 5, 2022 18:49
@SgtPooki
Copy link
Member

I changed a few things, and it should be ready to merge if CI passes

Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks for this. I also renamed the file and put it on the common directory to be consistent with the remaining constants. Once CI is green, I will merge.

@hacdias hacdias changed the title chore: created enum for ipcMain eventNames chore: create enum for ipcMain eventNames Jul 20, 2022
@hacdias hacdias merged commit 57525dd into ipfs:main Jul 20, 2022
@noliveira95 noliveira95 deleted the ipc-emit-enum branch July 27, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants