-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apple notarization of ipfs-desktop binary #2623
Comments
Seems like a new contract needed signed (by Wayne). It was signed and the CI seems to be succeeding now: https://github.com/ipfs/ipfs-desktop/actions/runs/6151308066/job/16727491264 Also, the failed warning indicates we will start having problems in a few months without some updates:
From electron/notarize#137 (comment), it seems like updating the call to {
//...
tool: 'notarytool',
teamId: '7Y229E2YRL' // team ID confirmed with Wayne and seems to be output here: https://github.com/ipfs/ipfs-desktop/actions/runs/6151308066/job/16727491264#step:12:67
} should be all we need. |
apple notarization is currently failing (see failing CI for #2621)
we have a PL apple developer account (as mentioned here), but I don't believe we're currently using that one for ipfs-desktop.
Either way, I don't have access to the one-password account that we're currently using for notarization.
I reached out to Andy to try and get us unblocked.
The text was updated successfully, but these errors were encountered: