Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make external links open in the system browser. #720

Closed
olizilla opened this issue Nov 28, 2018 · 0 comments · Fixed by #723
Closed

Make external links open in the system browser. #720

olizilla opened this issue Nov 28, 2018 · 0 comments · Fixed by #723
Assignees
@hacdias

Comments

@olizilla
Copy link
Member

It feel suprising that external links, to things like the go-ipfs github repo, open in another chromeless electron window. It would feel more natural if external links were opened in the default web browser for the system.
@hacdias hacdias mentioned this issue Nov 28, 2018
Merged
@ghost ghost added the in progress label Nov 28, 2018
hacdias added a commit that referenced this issue Nov 30, 2018
@hacdias
feat: open urls on default browser (#723)
f06cc59 
Open `http`/`https` links on default browser. I think it is safe to assume that all links we want to open in the default browser start with `http`. There aren't any other URL kinds on Web UI.

closes #720 

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@ghost ghost removed the in progress label Nov 30, 2018
@autonome autonome mentioned this issue Sep 9, 2019
Closed
@MarcelRaschke MarcelRaschke mentioned this issue Aug 20, 2022
Merged
@snyk-bot snyk-bot mentioned this issue Aug 21, 2022
Merged
@Kirobi92 Kirobi92 mentioned this issue Jun 23, 2023
Open
@0racl3z 0racl3z mentioned this issue Jun 23, 2023
Open
@Manny27nyc Manny27nyc mentioned this issue Jun 24, 2023
Open
@thexdesk thexdesk mentioned this issue Jun 24, 2023
Open
@baby636 baby636 mentioned this issue Jun 24, 2023
Open
@yng3 yng3 mentioned this issue Jun 24, 2023
Open
@irinazheltisheva irinazheltisheva mentioned this issue Jun 24, 2023
Open
@eliasbuchwald eliasbuchwald mentioned this issue Jun 24, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this issue Jun 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: open urls on default browser ipfs/ipfs-desktop
2 participants
@olizilla @hacdias