feat: new ctl #1302
feat: new ctl #1302
Conversation
|
Looked into this and make it work, but getting E2E tests to work requires bigger refactor than I thought. |
This fixes daemon init to respond correctly to IPFS_PATH override and refactors most of E2E tests to work with new ipfsd-ctl as well. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
There was a problem hiding this comment.
@hacdias check refactor in ddca144
refactor: ipfsd-ctl v1.x and IPFS_PATH
fixes daemon init to respond correctly to IPFS_PATH override
and refactors most of E2E tests to work with new ipfsd-ctl as well.
Note:
- I had to disable one of E2E tests because support for
IPFS_PATH/apiseems to be gone?
(Do you remember how we supported it a while ago?) npm run test:e2epass for me locally, but at CI does not pass (probably need to bump timeouts etc)
| const ipfsd = await factory.spawn({ | ||
| ipfsOptions: { | ||
| repo: path | ||
| }, |
There was a problem hiding this comment.
I believe basic init did not work because repo path got moved to ipfsOptions. This was the fix :)
There was a problem hiding this comment.
About the api file: I thought IPFS itself (or the controller) handled it! The only thing we did was this: #722.
#1302 License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
#1302 License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
|
I'm taking a new look at this on #1411. |
Closes #1137
@lidel I'm pretty sure you're more aware of the changes made to this version than I am. Could you give me a hand with this? Also, I noticed
ipfsd.stophangs and it does not take timeouts anymore...