Improve updating ux #1758
Merged
Improve updating ux #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @sutartmelson! Nice little fix. |
lidel
approved these changes
Feb 13, 2021
There was a problem hiding this comment.
Thank you @sutartmelson ❤️ 🙌
The code inside updateMenu gets crowded, but still acceptable, we can refactor it in separate PR when something else is added.
We will include this in Desktop release with go-ipfs 0.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides simple enhancements to UX when updating the client, addressing feedback brought up in #1488.
Normal state:
While checking for or downloading update:
This does not address everything mentioned in #1488, specifically snackbar notifications. I couldn't find an obvious way to do that without changing ipfs-webui, but i'm also very new to these projects so please advise if there's something I could have done.