Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: go-ipfs 0.10.0 #1896

Merged
merged 3 commits into from
Oct 1, 2021
Merged

feat: go-ipfs 0.10.0 #1896

merged 3 commits into from
Oct 1, 2021

Conversation

guseggert
Copy link
Contributor

No description provided.

@aschmahmann
Copy link

The fact that all the checks are passing here is a good sign and perhaps enough. However, looking through the history I see no recent usage of a go-ipfs RC here.

I'd like @lidel to fill us in once he's back on how he likes to deal with go-ipfs RC testing for IPFS Desktop.

Given the history and that the owner with the most context will be back in a couple of days I think we should not merge this, but call the tests passing a victory for now.

@guseggert guseggert changed the title feat: go-ipfs 0.10.0-rc1 feat: go-ipfs 0.10.0 Aug 27, 2021
@guseggert guseggert marked this pull request as draft August 27, 2021 00:55
@ipfs ipfs deleted a comment from welcome bot Sep 6, 2021
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Rebased, now we are just waiting for final release before the merge.

@lidel lidel added the P0 Critical: Tackled by core team ASAP label Sep 28, 2021
@lidel
Copy link
Member

lidel commented Sep 30, 2021

Note to self:

  • CI is flaky because fetching webui from public gateway fails sometimes.
  • Retry tomorrow, if the issue is still present, add some fallback

@lidel lidel marked this pull request as ready for review October 1, 2021 19:40
@guseggert guseggert merged commit 35b312a into main Oct 1, 2021
@guseggert guseggert deleted the feat/go-ipfs-0.10 branch October 1, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants