fix: macos autoupdate flow #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes macOS-specific code paths and replaces them with one unified logic for all three platforms (Windows/macOS/AppImage). It also fixes a bug where tray dissapears due to GC (it only worked because we had reference in ctx, but it could breat at any time)
This does not block main process nor interrupt user in any way. Notification can be safely ignored, in which case the update will be installed on exit.
lidel
force-pushed
the
fix/macos-autoupdate
branch
from
eaeec2e
to
9a17529
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes auto-update flow on macOS, which seems to have had a regression since v0.18.x (see electron-userland/electron-builder#6390)
macOS: 👉 if you are experiencing the infinite update dialog asking to "Restart" over and over again → please manually update to the latest version (
>=0.19.2)Sadly, this is not something we can fix automatically because old versions had macOS-specific autoupdate rules which disabled lazy upgrade on quit. This PR removes OS-specific code paths which should be less prone to regressions in the future.