Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show repo migration (go-ipfs 0.12.0) #1982

Merged
merged 9 commits into from
Mar 1, 2022
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Feb 17, 2022

Closes #1940 and closes #1823 + uses go-ipfs 0.12

Screenshot 2022-02-25 at 17 51 21

Screenshot 2022-02-25 at 17 50 51

@hacdias hacdias changed the title get ipfs logs feat: show repo migration Feb 17, 2022
@Carlos7687

This comment was marked as spam.

@hacdias
Copy link
Member Author

hacdias commented Feb 24, 2022

I will try to include #1823 in this PR too.

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias marked this pull request as ready for review February 25, 2022 16:54
@hacdias
Copy link
Member Author

hacdias commented Feb 25, 2022

@lidel can you please take a look? it should be ready

this also decreases the interval to make it more snappy
@lidel lidel changed the title feat: show repo migration feat: show repo migration (go-ipfs 0.12.0) Mar 1, 2022
@hacdias hacdias mentioned this pull request Mar 1, 2022
@lidel
Copy link
Member

lidel commented Mar 1, 2022

Added small fix that shows the migration window again after it is finished (so user who clicked "run in background" gets feedback when migration is finished and the IPFS node is running again):

2022-03-01_16-59

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hacdias!

Did some testing with 0.11 → 0.12 and UX should be more than enough for users with big repos.
Merging, as we want to ship ipfs-desktop with 0.12 this week.

this ensures that migration window will be shown again on error or on
success -- this way user who let it run in the background gets
feedback when their node is available again
@lidel lidel merged commit bb2d1ef into main Mar 1, 2022
@lidel lidel deleted the feat/show-repo-migration branch March 1, 2022 20:52
@gRoussac
Copy link

gRoussac commented Mar 8, 2022

Hi, just passing by to describe an issue I just had.

I installed the latest binary proposed go-ipfs_v0.11.0_linux-amd64.tar.gz and then wanted to have a look at the desktop version with ipfs-desktop-0.20.1-linux-amd64.deb which apparently installs v.0.12.

Then trying to run daemon again I got Your programs version (11) is lower than your repos (12)

Readme says go get -u github.com/ipfs/fs-repo-migrations but this failed with

package github.com/ipfs/fs-repo-migrations: no Go files in /home/greg/go/src/github.com/ipfs/fs-repo-migrations
I guess there is a path issue somewhere.

So I bascially deleted my config file and ipfs init again tu run go-ipfs version: 0.11.0 again.

Thanks

@hacdias
Copy link
Member Author

hacdias commented Mar 11, 2022

Hi @gRoussac! IPFS Desktop upgraded your repository to a newer version. You now need to update the binary you are using to run IPFS from 0.11 to 0.12.

I created a PR to update the docs to the newer version: ipfs/ipfs-docs#1074

@gRoussac
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show repository migration progress in go-ipfs 0.12+ Add meaningful GUI error when migration fails
5 participants