-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Refactor ctx #2114
fix: Refactor ctx #2114
Conversation
The failing workflow ( npm run test:e2e
> ipfs-desktop@0.20.5 test:e2e
> xvfb-maybe cross-env NODE_ENV=test playwright test test/e2e/launch.e2e.test.js
Running 10 tests using 1 worker
✓ test/e2e/launch.e2e.test.js:66:3 › Application launch › creates a repository on startup (5s)
✓ test/e2e/launch.e2e.test.js:80:3 › Application launch › starts fine when node is already running (4s)
✓ test/e2e/launch.e2e.test.js:88:3 › Application launch › applies config migration (MDNS.enabled) (4s)
✓ test/e2e/launch.e2e.test.js:109:3 › Application launch › applies config migration (Web UI CORS 1) (4s)
✓ test/e2e/launch.e2e.test.js:131:3 › Application launch › applies config migration (Web UI CORS 2) (4s)
✓ test/e2e/launch.e2e.test.js:152:3 › Application launch › applies config migration (Web UI CORS 3) (4s)
✓ test/e2e/launch.e2e.test.js:173:3 › Application launch › applies config migration (ConnMgr) (4s)
✓ test/e2e/launch.e2e.test.js:194:3 › Application launch › starts with repository with "IPFS_PATH/api" file and no daemon running (6s)
✓ test/e2e/launch.e2e.test.js:210:3 › Application launch › starts with multiple api addresses (4s)
✓ test/e2e/launch.e2e.test.js:222:3 › Application launch › starts with multiple gateway addresses (4s)
Slow test file: test/e2e/launch.e2e.test.js (42s)
Consider splitting slow test files to speed up parallel execution
10 passed (42s) |
I was able to install and run the dmg from the action artifact files at the bottom of https://github.com/ipfs/ipfs-desktop/actions/runs/2240299896. There are a few issues I'm seeing with the application, below is the content from the logs:
Which wasn't occurring with |
@SgtPooki what's the status on this? |
I've had to de-prioritize this due to other work, but I plan on picking this back up as time becomes available outside of the kubo-rpc-client work. |
superseded by #2378 |
ctx
probably still needs some additional optimizations, but this is a significant improvementMay help with #2113
fixes #1177