Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure .Swarm.ConnMgr exists before accessing #2255

Merged
merged 2 commits into from
Sep 23, 2022
Merged

fix: ensure .Swarm.ConnMgr exists before accessing #2255

merged 2 commits into from
Sep 23, 2022

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Sep 5, 2022

Fixes #2254 by adding a simple check to make sure .Swarm.ConnMgr actually exists in the configuration before changing it.

I thought about adding a test case for this, but then I would also have to add one for all the remaining migrations. However, I think that would almost duplicate the E2E time testing.

@hacdias hacdias changed the title fix: make sure .Swarm.ConnMgr exists before accessing fix: ensure .Swarm.ConnMgr exists before accessing Sep 5, 2022
@SgtPooki SgtPooki requested a review from a team as a code owner September 22, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot destructure property 'GracePeriod' of 'config.Swarm.Co
2 participants