-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release prep #2344
chore: release prep #2344
Conversation
lidel
commented
Nov 22, 2022
•
edited
Loading
edited
- kubo 0.17.0 (feat: kubo v0.17.0 #2338)
- bump some dependencies, if not a time sink
- locale sync
aacb102
to
39e5f0d
Compare
Seems the new version of electron-builder no longer does signing on PRs, which in turn breaks notarization. This seems to be a precaution for circleci, which we dont use – we use github actions, and afaik secrets are not exposed on PRs from forks (@galargh is that still true?). I can either undo |
Yes, that's correct. Workflows triggered on |
package got renamed and we were stuck on old version
94fc616
to
c25f514
Compare
c25f514
to
55f0051
Compare
Added two secrets to enable signing when secrets are present. ipfs-desktop/.github/workflows/ci.yml Lines 216 to 218 in 55f0051
This restored macOS signing on non-fork PRs. |
@galargh I'm merging this to unblock you. We want to make a new IPFS Desktop release to include Kubo 0.17 from #2338. Release steps are in https://github.com/ipfs/ipfs-desktop/blob/main/DEVELOPER-NOTES.md, but feel free to reach out if you need any assistance. |