Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release prep #2344

Merged
merged 4 commits into from
Dec 5, 2022
Merged

chore: release prep #2344

merged 4 commits into from
Dec 5, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Nov 22, 2022

@lidel
Copy link
Member Author

lidel commented Nov 23, 2022

Seems the new version of electron-builder no longer does signing on PRs, which in turn breaks notarization.

This seems to be a precaution for circleci, which we dont use – we use github actions, and afaik secrets are not exposed on PRs from forks (@galargh is that still true?).

I can either undo electron-builder update, or see if we can skip / enable signing on PRs without breaking the build.

@galargh
Copy link
Contributor

galargh commented Nov 25, 2022

Seems the new version of electron-builder no longer does signing on PRs, which in turn breaks notarization.

This seems to be a precaution for circleci, which we dont use – we use github actions, and afaik secrets are not exposed on PRs from forks (@galargh is that still true?).

I can either undo electron-builder update, or see if we can skip / enable signing on PRs without breaking the build.

Yes, that's correct. Workflows triggered on pull_request in general don't have access to secrets. pull_request_target does but we don't use it here.

package got renamed and we were stuck on old version
@lidel lidel force-pushed the chore/dependency-bumps branch 2 times, most recently from 94fc616 to c25f514 Compare December 5, 2022 17:38
@lidel lidel marked this pull request as ready for review December 5, 2022 18:25
@lidel lidel requested a review from a team as a code owner December 5, 2022 18:25
@lidel
Copy link
Member Author

lidel commented Dec 5, 2022

Added two secrets to enable signing when secrets are present.

# Force signing on PR IFF secrets are around
PUBLISH_FOR_PULL_REQUEST: ${{ secrets.PUBLISH_FOR_PULL_REQUEST }}
CSC_FOR_PULL_REQUEST: ${{ secrets.CSC_FOR_PULL_REQUEST }}

This restored macOS signing on non-fork PRs.

@lidel lidel enabled auto-merge (squash) December 5, 2022 18:41
@lidel lidel requested a review from galargh December 5, 2022 18:42
@lidel
Copy link
Member Author

lidel commented Dec 5, 2022

@galargh I'm merging this to unblock you.

We want to make a new IPFS Desktop release to include Kubo 0.17 from #2338.

Release steps are in https://github.com/ipfs/ipfs-desktop/blob/main/DEVELOPER-NOTES.md, but feel free to reach out if you need any assistance.

@lidel lidel disabled auto-merge December 5, 2022 18:51
@lidel lidel merged commit bab681a into main Dec 5, 2022
@lidel lidel deleted the chore/dependency-bumps branch December 5, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants