fix: tray translation waits for i18n init #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whizzzkid
approved these changes
Aug 29, 2023
src/i18n.js
Outdated
| @@ -26,6 +28,7 @@ module.exports = async function () { | |||
| } | |||
| }) | |||
| logger.info('[i18n] init done') | |||
| ctx.setProp('i18n_init_done', true) | |||
There was a problem hiding this comment.
would the context bloat too much if i18n instance is assigned to the context instead of just a boolean?
There was a problem hiding this comment.
I was thinking that, and I don't think it's necessary to store it in mem since we just need awareness of when the init is done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lazy-loading ctx feature didn't catch that i18n wasn't being init before tray translations were attempted.
That means the tray-menu-item translations were occurring prior to loading the
translation files, which defaults the translated result to the given key.
This PR resolves that problem.
fixes #2595