fix: ensure menu items update properly #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
changed the title
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2599
There was a previous bug with the menu that we fixed with #2594 but that resulted in some properties not being updated because we were updating a new
Menu.buildFromTemplateobject, and not callingtray.setContextMenu(menu)again.This fix reverts some of those changes, but still ensures that #2591 is not occurring.
This change also fixes an issue, probably introduced with the lazy ctx refactor, that prevented the systray menu items from being re-translated when the language was updated.