Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: remove the need for CORS headers #736

Closed
wants to merge 3 commits into from
Closed

wip: remove the need for CORS headers #736

wants to merge 3 commits into from

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Dec 7, 2018

@ghost ghost assigned hacdias Dec 7, 2018
@ghost ghost added the in progress label Dec 7, 2018
@hacdias
Copy link
Member Author

hacdias commented Dec 7, 2018

@lidel @olizilla we will need to enable window.ipfs on Web UI or create another way (like window.ipfsDesktop so Web UI knows we're talking to Desktop.

IMO, it would be easier to just enable window.ipfs when calling the ipfsReduxBundle on Web UI. It would just work. Right now, I'm injecting the ipfs object into the window. It seems to be working. It just isn't recognized by the Web UI

@hacdias
Copy link
Member Author

hacdias commented Dec 7, 2018

@olizilla @lidel I just updated this PR to use a version from Web UI that uses window.ipfs. You can try it out. We don't need CORS headers anymore.

We just need to merge ipfs/ipfs-webui#899 and this one 😄

Suggestions?

@hacdias hacdias requested review from olizilla and lidel and removed request for olizilla December 7, 2018 17:00
@hacdias hacdias changed the title wip: remove the need for CORS headers feat: remove the need for CORS headers Dec 7, 2018
@hacdias hacdias requested a review from olizilla December 7, 2018 17:01
@hacdias
Copy link
Member Author

hacdias commented Dec 8, 2018

Note to self: something that's happening: npm ci works; npm install gives an error on ipfs-postmsg-proxy. TODO: check what is updated.

@hacdias
Copy link
Member Author

hacdias commented Dec 8, 2018

image

So, we should really have another mechanism for IPFS Desktop like window.ipfsDesktop so we don't show this to the users.

@hacdias hacdias added this to the v0.6 milestone Dec 8, 2018
@hacdias hacdias changed the title feat: remove the need for CORS headers wip: remove the need for CORS headers Dec 8, 2018
@hacdias
Copy link
Member Author

hacdias commented Dec 8, 2018

will tidy up this PR.

@hacdias hacdias closed this Dec 8, 2018
@ghost ghost removed the in progress label Dec 8, 2018
@lidel
Copy link
Member

lidel commented Dec 9, 2018

Ideally there should be a separate attribute, eg. window.ipfsDesktop so there is no confusion about interface being direct, without any sandbox. (Support for this new attribute needs to be added to ipfs-redux-bundle first)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants