feat: ipfs on PATH on runtime

[hacdias]

Closes #727.

See #906 (comment)

[hacdias]

Just noticed that if the user says 'No', every time they start IPFS Desktop, they'll be prompted.

What do you think? If we add an option 'No, and don't ask' we should provide a way to undo it if the user happens to change its mind.

Also, keep in mind this only affects macOS users.

[fsdiogo]

Being nagged every time a user starts Desktop is no good.

I'd say we should just ask once, but have an option (a button for example) in the desktop specific settings to trigger the replacement.

[cwaring]

This sounds like a good candidate for some kind of status block (and/or switch) in the sidebar, indicating which IPFS binary you are using system wide.

[hacdias]

Hmm... I'm not sure if the status block would be a good way because this only affects macOS and it could require more work than what it's worth.

What if we show once and, if the user says no (or if /usr/local/bin/ipfs gets manually changed), we add an option (perhaps under Advanced or even in the main menu) to add it to PATH.

What do you think?

[cwaring]

That sounds like a good compromise to get this implemented and we can always revisit later.

If you install IPFS Desktop and IPFS isn't in the users path does we automatically set it up?

I ask because presenting people with decisions on initial load can be hostile, especially if it feels permanent and the user doesn't yet understand the benefits.

My suggestion would be:

• a) Add the configuration option in the settings and default to enabled if IPFS isn't currently found in the users path
• b) Incentivise them to enable it with a dialog (preferably after an acton is taken): If IPFS is already found, present a prompt explaining the benefit of using the desktop binary as default but with a sentence in the dialog saying: "This can be changed at any time from the settings page."
• c) Success 🥳

There may be other opportunities on the UI where we can present the option to enable this before an action is performed, such as first starting your node.

[hacdias]

@cwaring I get you, but let me give you a little more context:

1. On Windows, we add it to the PATH anyway during installation. No action required from the user.
2. On Linux, we add it to the PATH if not found already during installation. No action required from the user. Can't be changed later via IPFS Desktop.
3. On macOS, we do the same as we do on Linux but during runtime because it's possible. This way we have more flexibility and can ask the user if they want to replace it.

I just wanted to get feedback from more people too. /cc @olizilla @fsdiogo

[fsdiogo]

@hacdias my opinion hasn't changed => #906 (comment).

[hacdias]

So, just made some update: initially asks the user. If no, there will be an option under 'Advanced' to add to the PATH. It won't ask the user more times.

[hacdias]

As an update: I'll use this PR and do what's described here (#727 (comment)) on this PR. So'll change the status to WIP

[olizilla]

The current install prompts you with this

As we only prompt the user about installing the ipfs command if they already have one, this message should talk about the need to replace your existing command... how about:

---

Allow IPFS Desktop to update the IPFS CLI

IPFS desktop can keep the IPFS command-line interface (CLI) up to date. It will replace the existing ipfs command installed at /usr/local/bin/ipfs, and update it when new versions are available.

[ Update CLI ] [ Keep existing ]

---

[olizilla]

This CID should always be the latest release of ipfs-webui unless it depends on a pre-release version.

[hacdias]

@olizilla it's from the linked PR (ipfs/ipfs-webui#1016) and needed, yes.

[hacdias]

The current install prompts you with this

As we only prompt the user about installing the ipfs command if they already have one, this message should talk about the need to replace your existing command... how about:

Allow IPFS Desktop to update the IPFS CLI

IPFS desktop can keep the IPFS command-line interface (CLI) up to date. It will replace the existing ipfs command installed at /usr/local/bin/ipfs, and update it when new versions are available.

[ Update CLI ] [ Keep existing ]

Kinda. We also show it on Linux because there we always need permission. I'll update this later with a matrix of different messages.

[hacdias]

@olizilla updated the messages, depending on whether or using Windows, or you already have ipfs, or you don't have it but we need permission.

[lidel]

Did some QA for Linux: exec-root works only with polkit agent running

That is not a big problem, most of user-friendly distributions will have polkit agent running, but we should improve error handling, especially for advanced users without it (see below)

[hacdias]

I'm merging this and adding the missing Web UI PR to the list of the next release #880.