Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Simple Chat App Update #1161

Merged
merged 2 commits into from
May 27, 2022
Merged

Create Simple Chat App Update #1161

merged 2 commits into from
May 27, 2022

Conversation

TheDiscordian
Copy link
Member

@TheDiscordian TheDiscordian commented May 26, 2022

Updated diagram, changed links to be up-to-date, removed Docker section, added warning about circuit-relay v1 removal from go-ipfs & linked to a repo with most of the code needed to use the chat app /w a relay (but missing pubsub & the ability to list addrs, so no announcing) fixes towards #1146

This simply makes the guide correct again, however doesn't instruct the user on how to setup a circuit-relay anymore. The reason for this being is go-libp2p-relay-daemon doesn't currently have any way to:

  1. Announce over pubsub
  2. List connected addresses

So unless I missed something, while it's awesome having most of the hard work needed done, it's still not enough to bring life to using circuit-relay in a browser right now, not that I can figure out anyways. In the future I or someone else can likely take the Python script which is used for advertising currently, and build a custom libp2p node that bundles the pubsub announces right into it, which would completely solve the problem.

…on, added warning about circuit-relay v1 removal from go-ipfs & linked to a repo with most of the code needed to use the chat app /w a relay (but missing pubsub & the ability to list addrs, so no announcing) fixes #1146
Copy link
Contributor

@johnnymatthews johnnymatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merge when ready.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as band-aid (adds note that go-ipfs 0.11 needs to be used), but does not remove references to deprecated EnableRelayHop from our docs.

We should keep #1146 open until we remove all mentions.

@lidel lidel merged commit f15a206 into ipfs:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants