-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🗑️ Deprecation notice for js-ipfs #1628
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ description: Learn about the available node types in IPFS Companion. | |
|
||
# Understand node types in IPFS Companion | ||
|
||
IPFS Companion's preferences screen allows you to choose from several different node types. The available types you'll see in your Companion preferences depends on the browser you're using (i.e. Firefox, Chrome, Brave), but the full list is as follows: | ||
IPFS Companion's preferences screen allows you to choose from different node types. The available types you'll see in your Companion preferences depends on the browser you're using (i.e. Firefox, Chrome, Brave), but the full list is as follows: | ||
|
||
[[toc]] | ||
|
||
|
@@ -67,6 +67,12 @@ This node type offers the same benefits as an [external](#external) node, with a | |
|
||
## Embedded | ||
|
||
::: warning DEPRECATED | ||
|
||
js-ipfs has been deprecated in favor of [Helia](https://github.com/ipfs/helia) and will be removed in a future release of IPFS Companion. Improvements to Helia are ongoing, and we hope to have it ready for use in IPFS Companion once critical features like [webRTC Streams](https://github.com/w3c/webextensions/issues/72) are available in Chrome Manifest V3. | ||
|
||
::: | ||
Comment on lines
+70
to
+74
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @whizzzkid : I think this just adds noise. This can be in our backlogged but this was a non-functioning feature. I think we should just strip it out. |
||
|
||
An _embedded_ node is a js-ipfs instance running in the browser in-memory, without the need for any external software. | ||
|
||
::: warning | ||
|
@@ -75,6 +81,14 @@ This node type is only for development and experimentation. Most users should us | |
|
||
::: | ||
|
||
::: warning Deprecation Notice for Chrome Manifest V3 | ||
|
||
Chrome Manifest V3 is the new version of the Chrome extension platform that IPFS Companion will support in the near future. Currently, the embedded node type is unavailable in Chrome MV3 and will be removed from the extension in a future release. For further information, see the [tracking issue in GitHub](https://github.com/ipfs/ipfs-companion/issues/1152). | ||
|
||
If you're using the embedded node type in Chrome, please switch to the external node type instead. | ||
|
||
::: | ||
|
||
Power users can provide [custom config](https://github.com/ipfs/js-ipfs#faq) (e.g. to enable experimental pubsub) via the IPFS Companion [Preferences](https://user-images.githubusercontent.com/157609/38084660-0b97c0cc-334e-11e8-9368-823345ced67f.png) | ||
|
||
Please note that there are some limitations when running an embedded js-ipfs instance in the browser context using Companion: | ||
|
@@ -87,12 +101,6 @@ Please note that there are some limitations when running an embedded js-ipfs ins | |
- Missing relay discovery ([js-ipfs/v0.29.x/examples/circuit-relaying](https://github.com/ipfs/js-ipfs/tree/v0.29.3/examples/circuit-relaying)) | ||
- An embedded node _does not run_ when an external node is selected; every time you switch back to the embedded node, a new instance is created on demand, and it can take a few seconds for a newly running node to find peers. | ||
|
||
### Embedded + `chrome.sockets` (deprecated) | ||
|
||
::: warning | ||
This node type has been deprecated and is no longer supported by Chromium browsers. While this option still appears in IPFS Companion preferences, users of this node type are strongly urged to migrate to a different node type. | ||
::: | ||
|
||
## Public | ||
|
||
A _public_ node is used as a fallback for gateway functionality when an external node is offline or an embedded node is used. It does not expose the API port. This type of node is not included as an option in Companion's preferences. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just remove the full Embedded section?