Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document config initialization with envs #856

Closed
wants to merge 2 commits into from
Closed

Conversation

vk496
Copy link

@vk496 vk496 commented Aug 5, 2021

Documentation of feature from ipfs/kubo#8326

@welcome
Copy link

welcome bot commented Aug 5, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
  • Your contribution itself is clear (grammar and spelling checked, any code blocks checked and commented) and in its best form. Follow the docs contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
  • The PR gets reviews, discussed and approvals as needed.
  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Contributor

@johnnymatthews johnnymatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help here @vk496. I've made some minor tweaks.

Blocked

Gonna wait on ipfs/kubo#8326 before this gets merged.

docs/how-to/run-ipfs-inside-docker.md Show resolved Hide resolved
docs/how-to/run-ipfs-inside-docker.md Outdated Show resolved Hide resolved
docs/how-to/run-ipfs-inside-docker.md Outdated Show resolved Hide resolved
docs/how-to/run-ipfs-inside-docker.md Outdated Show resolved Hide resolved
@johnnymatthews johnnymatthews added the status/blocked Unable to be worked further until needs are met label Aug 5, 2021
@vk496
Copy link
Author

vk496 commented Aug 6, 2021

Thank you @johnnymatthews

Just one thing that I was not sure how to deal: indicate minimum required version.

Most Docker users expect environment override as a basic feature. They will see the instructions for using it and would try it, in the best case, with the latest stable version (which will not do what they expect and not fail)

@johnnymatthews
Copy link
Contributor

indicate minimum required version - @vk496

Minimum version of IPFS? Or Docker? Or both?

@vk496
Copy link
Author

vk496 commented Aug 6, 2021

Minimum version of IPFS? Or Docker? Or both?

Docker images of IPFS. https://hub.docker.com/r/ipfs/go-ipfs/tags

@lidel
Copy link
Member

lidel commented Sep 3, 2021

We decided on a different approach, as this one had some gaps.
See ipfs/kubo#8326 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/blocked Unable to be worked further until needs are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants