feat: add 3 retries for the fallback HTTP downloads #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/http-retry
branch
from
a838de8
to
cb5b190
Compare
aschmahmann
force-pushed
the
feat/http-retry
branch
from
cb5b190
to
2e19c24
Compare
|
While this PR might help a little, it's not great because of ipfs/kubo#8714 |
lidel
requested changes
Feb 10, 2022
There was a problem hiding this comment.
Sounds like we need changes described in ipfs/kubo#8714 (comment) – perhaps this PR could be repurposed for that refactor?
|
Yep I think we can grab the retry logic from here and put it in ipfs/kubo#8728 |
aschmahmann
force-pushed
the
feat/http-retry
branch
from
034d8c7
to
348acda
Compare
aschmahmann
force-pushed
the
feat/http-retry
branch
from
348acda
to
668d3ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.