Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharness support and tests #5

Merged
merged 9 commits into from
Dec 8, 2015
Merged

Conversation

chriscool
Copy link
Contributor

This adds sharness support to test ipfs-update and then tests to test it.

For now only the following commands are tested:

  • ipfs-update version
  • ipfs-update versions
  • ipfs-update install

but should not be very difficult to add tests for the rest:

  • ipfs-update revert
  • ipfs-update fetch

This uses docker so that ipfs-update installs ipfs on a docker container, to avoid polluting the machine running the tests.

@chriscool chriscool mentioned this pull request Dec 4, 2015
21 tasks
@@ -0,0 +1,32 @@
#!/bin/sh

test_description="Show basic features of Sharness"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea! 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, this is great

@jbenet
Copy link
Member

jbenet commented Dec 5, 2015

This uses docker so that ipfs-update installs ipfs on a docker container, to avoid polluting the machine running the tests.

this is great stuff! i look fwd to dockerized tests for go-ipfs, too!

will these run on travis-ci? i believe they can, but we may need to do something special: https://docs.travis-ci.com/user/docker/

  • enable travis for this repo (@jbenet)
  • make travis run the tests (inc docker)

@jbenet
Copy link
Member

jbenet commented Dec 5, 2015

@chriscool 👏 👏 here

@chriscool
Copy link
Contributor Author

@jbenet thanks!

Yeah, I can take a look at running this on Travis-CI maybe tomorrow or on Monday.

@whyrusleeping
Copy link
Member

@chriscool youre the best, this is awesome

@chriscool chriscool force-pushed the sharness-support branch 2 times, most recently from 3ffbfe3 to 82c36a4 Compare December 7, 2015 22:04
@chriscool
Copy link
Contributor Author

I added a .travis.yml that run the sharness tests on Linux and tests passed!

I first tried with Mac OS X too, but it looks like docker is not available there:

https://travis-ci.org/ipfs/ipfs-update/jobs/95448885

@chriscool
Copy link
Contributor Author

@jbenet and @whyrusleeping could you take a look at the travis file and at merging or commenting on this? Thanks!

language: go

go:
- 1.5.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use 1.5.2, it fixed a bug we've been seeing for a while.

@whyrusleeping
Copy link
Member

just need to bump go version to 1.5.2 and this LGTM

@chriscool
Copy link
Contributor Author

It's using 1.5.2 now!

@whyrusleeping
Copy link
Member

cool, lgtm. merging!

whyrusleeping added a commit that referenced this pull request Dec 8, 2015
@whyrusleeping whyrusleeping merged commit 3f572ab into ipfs:master Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants