-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharness support and tests #5
Conversation
@@ -0,0 +1,32 @@ | |||
#!/bin/sh | |||
|
|||
test_description="Show basic features of Sharness" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, this is great
this is great stuff! i look fwd to dockerized tests for go-ipfs, too! will these run on travis-ci? i believe they can, but we may need to do something special: https://docs.travis-ci.com/user/docker/
|
@chriscool 👏 👏 here |
@jbenet thanks! Yeah, I can take a look at running this on Travis-CI maybe tomorrow or on Monday. |
@chriscool youre the best, this is awesome |
3ffbfe3
to
82c36a4
Compare
I added a .travis.yml that run the sharness tests on Linux and tests passed! I first tried with Mac OS X too, but it looks like docker is not available there: |
@jbenet and @whyrusleeping could you take a look at the travis file and at merging or commenting on this? Thanks! |
language: go | ||
|
||
go: | ||
- 1.5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets use 1.5.2, it fixed a bug we've been seeing for a while.
just need to bump go version to 1.5.2 and this LGTM |
82c36a4
to
25f9f5e
Compare
It's using 1.5.2 now! |
cool, lgtm. merging! |
Sharness support and tests
This adds sharness support to test ipfs-update and then tests to test it.
For now only the following commands are tested:
but should not be very difficult to add tests for the rest:
This uses docker so that ipfs-update installs ipfs on a docker container, to avoid polluting the machine running the tests.