Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning integration: Solve for "pins" item in File screen info bar #1505

Closed
3 of 4 tasks
jessicaschilling opened this issue May 28, 2020 · 4 comments · Fixed by #1513
Closed
3 of 4 tasks

Pinning integration: Solve for "pins" item in File screen info bar #1505

jessicaschilling opened this issue May 28, 2020 · 4 comments · Fixed by #1513
Assignees
Labels
area/pinning Integrating pinning into GUI apps effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P0 Critical: Tackled by core team ASAP status/in-progress In progress topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design topic/design-visual Visual design ONLY, not part of a larger UX effort

Comments

@jessicaschilling
Copy link
Contributor

jessicaschilling commented May 28, 2020

Note: This issue is part of a larger pinning service integration epic undertaken spring/summer 2020.

In brief

Once pinning services are better integrated into Web UI, the "pins" item in the File screen info bar will benefit considerably from refining — either adding additional explanatory context, or repurposing altogether.

image

  • Discuss best-case UX for this info bar once pinning services have been added
  • Determine functional requirements
  • Draw up, discuss and agree upon UI instantiation
  • Implement as a PR to close this issue, or if it's a substantial enough effort, open and resolve a new issue for implementation

This isn't critical work for MVP release, but is high on a nice-to-have list.

@jessicaschilling jessicaschilling changed the title Pinning integration: Solve for "pins" in File screen info bar Pinning integration: Solve for "pins" item in File screen info bar May 28, 2020
@jessicaschilling jessicaschilling added the area/pinning Integrating pinning into GUI apps label May 28, 2020
@jessicaschilling jessicaschilling self-assigned this May 28, 2020
@jessicaschilling jessicaschilling added kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP labels May 28, 2020
@jessicaschilling jessicaschilling added exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week need/analysis Needs further analysis before proceeding status/in-progress In progress topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design topic/design-visual Visual design ONLY, not part of a larger UX effort labels May 28, 2020
@jessicaschilling
Copy link
Contributor Author

@lidel -- I assume there isn't any reasonably efficient way to actually display the file/folder names in the Pins screen that appears when someone clicks that "pins" link?

If there isn't, I wonder if as first step we actually just remove that link entirely (still displaying the number of pins, just removing the link). If Web UI/Desktop is effectively acting as a file browser in the Files screen (and the similar Pins screen), withholding the name of the files removes what's really the primary use case.

@lidel
Copy link
Member

lidel commented Jun 1, 2020

I assume there isn't any reasonably efficient way to actually display the file/folder names in the Pins screen that appears when someone clicks that "pins" link?

No way atm. We dont store any labels/names within current pinning API in go-ipfs.
(The "new pinning service API" may include additional metadata, including filenames, but it does not exist in go-ipfs yet)

  • I'd vote for removing "pins" item from info bar (we can reconsider when/if a better API for managing pins lands in go-ipfs)
  • (optional/nice to haves) tweak the info bar to show stats about current directory, making it more useful
    • make it clear stats are about current directory (size, file/dir count)
    • when I am in root, it shows size of all files
    • if i open a subdir, it shows how big current dir is (+perhaps what party of total storage it takes?)

@jessicaschilling
Copy link
Contributor Author

Like so? (Current is on top, idea for viewing a subdirectory is on bottom.)
image
Note two things:

  • "Files" here isn't clickable; user can get there from breadcrumbs that already live directly to the left, and there doesn't seem to be much point in just offering a link to top-level directory anyway
  • We'd have to decide if we wanted to keep the "XGB/YGB" visual dichotomy for the top level, or just get rid of everything after the slash for that highest level directory. (Pros to keeping it: consistency; cons: repetition.)

@jessicaschilling
Copy link
Contributor Author

Per conversation with @rafaelramalho19 and @lidel:

  • Remove middle "blocks" area
  • Rename "repo" to "all blocks"
  • For top-level directory, keep the smaller gray text "/xxxMB"

Like so:
image

@rafaelramalho19, please let me know if you need anything else from me -- note that the subtitles ("files", "all files") are slightly smaller in this version than existing (2px smaller) and the same size text as the gray "/xxxMB" text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pinning Integrating pinning into GUI apps effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P0 Critical: Tackled by core team ASAP status/in-progress In progress topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design topic/design-visual Visual design ONLY, not part of a larger UX effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants