Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/redesign files bar #1513

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Feat/redesign files bar #1513

merged 4 commits into from
Jul 22, 2020

Conversation

rafaelramalho19
Copy link
Contributor

Closes #1505

End result:
image
image

@rafaelramalho19 rafaelramalho19 self-assigned this Jun 3, 2020
@rafaelramalho19 rafaelramalho19 added the kind/enhancement A net-new feature or improvement to an existing feature label Jun 3, 2020
@jessicaschilling
Copy link
Contributor

That was fast 😊
Three requests, please, per #1505 (comment) ?

  • "Files" shouldn't be clickable
  • Please remove "Pins" area entirely
  • For top-level directory, keep the smaller gray text "/xxxMB"

Thank you!

lidel
lidel reviewed Jun 4, 2020
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and clean now! ❤️

2020-06-04--23-49-56

Two concerns (unsure if a big deal – would appreciate your thoughts):

  • removing "pins" screen without giving "pinning services" feature in return may feel to some users like a regression in functionality
    • are we keeping code responsible for pins screen?
  • is "all blocks" (label I suggested) clear enough? I worry the huge size discrepancy between MFS and entire repo is still not explained well by these labels:

    2020-06-04--23-50-56
    2020-06-04--23-54-30
    Thoughts? Is it fine, or should we get more eyes on this, before merging? Suggestions of better labels?

@jessicaschilling
Copy link
Contributor

jessicaschilling commented Jun 5, 2020 •
edited
Loading

  • I don't see any reason why we need to release this any earlier than the pinning services release (whatever that one will be!): you're right, @lidel, in that we'd be removing functionality if we do it earlier. Good call.
  • "all blocks" -> "all data"? "all IPFS data"? We want to make it clear that this is the difference between "your" files and all the stuff that isn't "yours" but that you're providing/reproviding to other peers. We could change the "files" label to "your files" to emphasize that distinction but I don't know if that's strictly correct.

@rafaelramalho19
Copy link
Contributor Author

@lidel and @jessicaschilling should I change the merge request target to epic/pinning-services and merge it? That way it just ships whenever pinning services is integrated fully 😄

@jessicaschilling
Copy link
Contributor

I'll leave that up to @lidel ...

@rafaelramalho19 rafaelramalho19 changed the base branch from master to epic/pinning-services July 22, 2020 16:41
@rafaelramalho19 rafaelramalho19 merged commit f0b6491 into epic/pinning-services Jul 22, 2020
@rafaelramalho19 rafaelramalho19 deleted the feat/redesign-files-bar branch July 22, 2020 16:41
@lidel lidel mentioned this pull request Sep 25, 2020
Closed
rafaelramalho19 added a commit that referenced this pull request Sep 29, 2020
@rafaelramalho19
Feat/redesign files bar (#1513)
9dbf928
rafaelramalho19 added a commit that referenced this pull request Oct 6, 2020
@rafaelramalho19
Feat/redesign files bar (#1513)
8de9712
rafaelramalho19 added a commit that referenced this pull request Nov 3, 2020
@rafaelramalho19
Feat/redesign files bar (#1513)
edb8bee
rafaelramalho19 added a commit that referenced this pull request Nov 10, 2020
@rafaelramalho19
Feat/redesign files bar (#1513)
5fcb1ba
rafaelramalho19 added a commit that referenced this pull request Dec 14, 2020
@rafaelramalho19 @jessicaschilling @lidel
feat: pinning services stage 1 (#1685)
2a312a3 
* Feat/pinning settings (#1535)

* Feat/pinning settings custom modal (#1546)

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* Feat/redesign files bar (#1513)

* Feat/pinning settings (#1535) (#1557)

* feat: add pinning services service modal

* chore: update translation for service modal

* chore: fix tslint in directory selector

* chore: fix tscheck issues in upper directory selector

* chore: fix tslint in selectors

* feat: add pinning to files page (#1678)

* chore: refactor files page

* feat: add pinning services mock to files page

* chore: update remotePin dimensions

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update local pin icon dimension

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: change pin icon fill color

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: change remote pin icon fill color

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update pinning modal text size

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update pinning modal text size

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: pinning modal secondary text changes

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update pinning modal image size

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update pinning modal pin icon

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: add pin status column to fileslist

* chore: fix modals icons

* chore: fix linting error

* chore: fix files sorting

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* feat: prepare pinning services for stage 1

* chore: remove remote pins from settings page for stage 1

* chore: update pinning manager padding

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update modal horizontal padding

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: make settings page pinning table responsive

* chore: update settings page description in pinning table

* chore: update header style

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update settings page in smaller viewports

* chore: remove outline on pinning tables focus

* chore: update translation

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update translation

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: add titles to bar options

* chore: add titles to bar options

* Update public/locales/en/files.json

* feat: add pins size to the settings page

* feat: add number of pins to settings page

* chore: feat tslint

* chore: fix error in button

* test(e2e): more reliable api test suite

This changes the way we enter API address/config from programmatic
to full simulation of user input and adds tiny slow down between each
key stroke.

This should solve the problem of newly added UI feedback not engaging,
and make CI both more reliable and green again.

While at it, made it CI-agnostic, in preparation for move to
GithubActions

Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
rafaelramalho19 added a commit that referenced this pull request Dec 14, 2020
@rafaelramalho19
Feat/redesign files bar (#1513)
83cefcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel left review comments

@jessicaschilling jessicaschilling Awaiting requested review from jessicaschilling

Assignees

@rafaelramalho19 rafaelramalho19

Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pinning integration: Solve for "pins" item in File screen info bar
3 participants
@rafaelramalho19 @jessicaschilling @lidel