Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pinning settings (#1535) #1557

Merged

Conversation

rafaelramalho19
Copy link
Contributor

No description provided.

@rafaelramalho19 rafaelramalho19 self-assigned this Jul 23, 2020
@rafaelramalho19 rafaelramalho19 changed the base branch from master to epic/pinning-services July 23, 2020 18:15
Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a translation string got search/replaced incorrectly, but that's all I've got; let me know if I need to review anything in serious depth, thanks!

@rafaelramalho19 rafaelramalho19 merged commit c5640dd into epic/pinning-services Aug 17, 2020
@rafaelramalho19 rafaelramalho19 deleted the feat/pinning-services-service-modal branch August 17, 2020 15:35
rafaelramalho19 added a commit that referenced this pull request Sep 29, 2020
* feat: add pinning services service modal

* chore: update translation for service modal
rafaelramalho19 added a commit that referenced this pull request Oct 6, 2020
* feat: add pinning services service modal

* chore: update translation for service modal
rafaelramalho19 added a commit that referenced this pull request Nov 3, 2020
* feat: add pinning services service modal

* chore: update translation for service modal
rafaelramalho19 added a commit that referenced this pull request Nov 10, 2020
* feat: add pinning services service modal

* chore: update translation for service modal
rafaelramalho19 added a commit that referenced this pull request Dec 14, 2020
* Feat/pinning settings (#1535)

* Feat/pinning settings custom modal (#1546)

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* Feat/redesign files bar (#1513)

* Feat/pinning settings (#1535) (#1557)

* feat: add pinning services service modal

* chore: update translation for service modal

* chore: fix tslint in directory selector

* chore: fix tscheck issues in upper directory selector

* chore: fix tslint in selectors

* feat: add pinning to files page (#1678)

* chore: refactor files page

* feat: add pinning services mock to files page

* chore: update remotePin dimensions

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update local pin icon dimension

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: change pin icon fill color

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: change remote pin icon fill color

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update pinning modal text size

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update pinning modal text size

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: pinning modal secondary text changes

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update pinning modal image size

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update pinning modal pin icon

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: add pin status column to fileslist

* chore: fix modals icons

* chore: fix linting error

* chore: fix files sorting

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* feat: prepare pinning services for stage 1

* chore: remove remote pins from settings page for stage 1

* chore: update pinning manager padding

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update modal horizontal padding

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: make settings page pinning table responsive

* chore: update settings page description in pinning table

* chore: update header style

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update settings page in smaller viewports

* chore: remove outline on pinning tables focus

* chore: update translation

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: update translation

Co-authored-by: Jessica Schilling <jessica@protocol.ai>

* chore: add titles to bar options

* chore: add titles to bar options

* Update public/locales/en/files.json

* feat: add pins size to the settings page

* feat: add number of pins to settings page

* chore: feat tslint

* chore: fix error in button

* test(e2e): more reliable api test suite

This changes the way we enter API address/config from programmatic
to full simulation of user input and adds tiny slow down between each
key stroke.

This should solve the problem of newly added UI feedback not engaging,
and make CI both more reliable and green again.

While at it, made it CI-agnostic, in preparation for move to
GithubActions

Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
rafaelramalho19 added a commit that referenced this pull request Dec 14, 2020
* feat: add pinning services service modal

* chore: update translation for service modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants