Enabling WebTransport in Kubo v0.16.0-rc1 breaks Status page #2033

lidel · 2022-09-27T13:28:42Z

How to reproduce

Run Kubo v0.16.0-rc1
Enable WebTransport by
1. adding "/ip4/0.0.0.0/udp/4002/quic/webtransport" to Addresses.Swarm
2. enabling transport via ipfs config Swarm.Transports.Network.WebTransport --json true
Restart node
Open webui

See Release Notes for more info: https://github.com/ipfs/kubo/blob/master/docs/changelogs/v0.16.md

Broken state

Suspected cause

Guess: ipfs.id output breaks the way we present ADDRESSES on the Status page.
I see ipfs-webui in infinite loop trying to read /api/v0/id over and over again.

New type of addresses is now returned as part of Addresses list, values look like this:

"/ip4/47.22.210.45/udp/55918/quic/webtransport/certhash/uEiAkH5a4DPGKUuOBjYw0CgwjvcJCJMD2K_1aluKR_tpevQ/certhash/uEiAfbgiymPP2_nX7Dgir8B4QkksjHp2lVuJZz0F79Be9JA/p2p/12D3KooWBdmLJjhpgJ9KZgLM3f894ff9xyBfPvPjFNn7MKJpyrC2"

cc ipfs/kubo#9237
@SgtPooki or @hacdias will you have time to take a look? Ideally we would fix this and ship new ipfs-webui and update Kubo 0.16 ships.

The text was updated successfully, but these errors were encountered:

SgtPooki · 2022-09-27T17:26:52Z

I've got kubo 0.16 rc1 running locally against webui right now, working on repro

SgtPooki · 2022-09-27T17:32:21Z

repro:

SgtPooki · 2022-09-27T17:42:22Z

err:  Error: no protocol with name: webtransport
    at Protocols (protocols-table.js:15:1)
    at stringToStringTuples (codec.js:45:1)
    at stringToBytes (codec.js:182:1)
    at Object.fromString (codec.js:190:1)
    at __webpack_modules__../node_modules/multiaddr/src/index.js.withIs.proto.className (index.js:46:1)
    at new <anonymous> (index.js:40:1)
    at __webpack_modules__../node_modules/multiaddr/src/index.js.withIs.proto.className (index.js:29:1)
    at index.js:40:1
    at id.js:24:1
    at Array.map (<anonymous>)

> rg 'const res = await api.post\('\''id' node_modules

node_modules/ipfs-core/node_modules/ipfs-http-client/src/id.js
18:    const res = await api.post('id', {

node_modules/ipfs-cli/node_modules/ipfs-http-client/src/id.js
18:    const res = await api.post('id', {

node_modules/ipfs-http-client/src/id.js
13:    const res = await api.post('id', {

node_modules/ipfs-client/node_modules/ipfs-http-client/src/id.js
17:    const res = await api.post('id', {

SgtPooki · 2022-09-27T18:05:31Z

Looks like the line throwing is https://github.com/multiformats/js-multiaddr/blob/aac01444747526149c8bff73e054597b61481007/src/protocols-table.js#L18

we're on multiaddr version 8.1.2 which doesn't support webtransport since it was just added 7 days ago multiformats/js-multiaddr@210f156 to version 11

╰─ ✔ ❯ npm ls multiaddr

ipfs-webui@2.18.1 /Users/sgtpooki/code/work/protocol.ai/ipfs/webui
├─┬ ipfs-http-client@49.0.2
│ ├─┬ ipfs-core-types@0.3.1
│ │ └── multiaddr@8.1.2 deduped
│ ├─┬ ipfs-core-utils@0.7.2
│ │ └── multiaddr@8.1.2 deduped
│ └── multiaddr@8.1.2 deduped
├─┬ ipfs@0.58.3
│ ├─┬ ipfs-cli@0.8.8
│ │ ├─┬ ipfs-core-types@0.7.3
│ │ │ └── multiaddr@10.0.1 deduped
│ │ ├─┬ ipfs-core-utils@0.10.5
│ │ │ ├─┬ ipfs-core-types@0.7.3
│ │ │ │ └── multiaddr@10.0.1 deduped
│ │ │ ├─┬ multiaddr-to-uri@8.0.0
│ │ │ │ └── multiaddr@10.0.1 deduped
│ │ │ └── multiaddr@10.0.1
│ │ ├─┬ ipfs-daemon@0.9.8
│ │ │ ├─┬ ipfs-core-types@0.7.3
│ │ │ │ └── multiaddr@10.0.1
│ │ │ ├─┬ ipfs-grpc-server@0.6.6
│ │ │ │ ├─┬ ipfs-core-types@0.7.3
│ │ │ │ │ └── multiaddr@10.0.1 deduped
│ │ │ │ └── multiaddr@10.0.1
│ │ │ ├─┬ ipfs-http-gateway@0.6.5
│ │ │ │ ├─┬ ipfs-core-types@0.7.3
│ │ │ │ │ └── multiaddr@10.0.1
│ │ │ │ ├─┬ is-ipfs@6.0.2
│ │ │ │ │ ├─┬ mafmt@10.0.0
│ │ │ │ │ │ └── multiaddr@10.0.1 deduped
│ │ │ │ │ └── multiaddr@10.0.1 deduped
│ │ │ │ └─┬ uri-to-multiaddr@6.0.0
│ │ │ │   └── multiaddr@10.0.1
│ │ │ └─┬ ipfs-http-server@0.7.6
│ │ │   ├─┬ ipfs-core-types@0.7.3
│ │ │   │ └── multiaddr@10.0.1 deduped
│ │ │   └── multiaddr@10.0.1
│ │ ├─┬ ipfs-http-client@52.0.5
│ │ │ └── multiaddr@10.0.1 deduped
│ │ ├─┬ mafmt@10.0.0
│ │ │ └── multiaddr@10.0.1 deduped
│ │ ├─┬ multiaddr-to-uri@8.0.0
│ │ │ └── multiaddr@10.0.1 deduped
│ │ └── multiaddr@10.0.1
│ └─┬ ipfs-core@0.10.8
│   ├─┬ ipfs-bitswap@6.0.3
│   │ ├─┬ libp2p-interfaces@1.3.1
│   │ │ └── multiaddr@10.0.1
│   │ └── multiaddr@10.0.1
│   ├─┬ ipfs-core-types@0.7.3
│   │ └── multiaddr@10.0.1 deduped
│   ├─┬ ipfs-http-client@52.0.5
│   │ └── multiaddr@10.0.1 deduped
│   ├─┬ is-ipfs@6.0.2
│   │ └── multiaddr@10.0.1 deduped
│   ├─┬ libp2p-bootstrap@0.13.0
│   │ ├─┬ mafmt@10.0.0
│   │ │ └── multiaddr@10.0.1 deduped
│   │ └── multiaddr@10.0.1
│   ├─┬ libp2p-delegated-content-routing@0.11.0
│   │ └── multiaddr@10.0.1
│   ├─┬ libp2p-kad-dht@0.24.2
│   │ └── multiaddr@10.0.1
│   ├─┬ libp2p-mdns@0.17.0
│   │ └── multiaddr@10.0.1
│   ├─┬ libp2p-tcp@0.17.2
│   │ ├─┬ libp2p-utils@0.4.1
│   │ │ └── multiaddr@10.0.1
│   │ ├─┬ mafmt@10.0.0
│   │ │ └── multiaddr@10.0.1 deduped
│   │ └── multiaddr@10.0.1
│   ├─┬ libp2p-webrtc-star@0.23.0
│   │ ├─┬ mafmt@10.0.0
│   │ │ └── multiaddr@10.0.1 deduped
│   │ └── multiaddr@10.0.1
│   ├─┬ libp2p-websockets@0.16.1
│   │ ├─┬ mafmt@10.0.0
│   │ │ └── multiaddr@10.0.1 deduped
│   │ ├─┬ multiaddr-to-uri@8.0.0
│   │ │ └── multiaddr@10.0.1 deduped
│   │ └── multiaddr@10.0.1
│   ├─┬ libp2p@0.32.5
│   │ ├─┬ mafmt@10.0.0
│   │ │ └── multiaddr@10.0.1 deduped
│   │ └── multiaddr@10.0.1
│   ├─┬ mafmt@10.0.0
│   │ └── multiaddr@10.0.1 deduped
│   ├─┬ multiaddr-to-uri@8.0.0
│   │ └── multiaddr@10.0.1 deduped
│   └── multiaddr@10.0.1
├─┬ ipfsd-ctl@7.2.0
│ └── multiaddr@8.1.2 deduped
├─┬ is-ipfs@3.0.0
│ ├─┬ mafmt@8.0.4
│ │ └── multiaddr@8.1.2 deduped
│ └── multiaddr@8.1.2 deduped
├─┬ multiaddr-to-uri@6.0.0
│ └── multiaddr@8.1.2 deduped
└── multiaddr@8.1.2

see #2033

SgtPooki · 2022-09-27T19:13:23Z

attempted a quick fix but was unsuccessful:

fc939b7 results in an error

98587cb results in another error:

Failed to get identity Error: invalid character 'u' in 'uEiD1qy_pwUXrusX6CufD-gipAzNSz52OVOhJUUOLpmmMNw'
    at Base.decode (base.js:43:1)
    at fromString (from-string.js:51:1)
    at Function.convertToBytes [as toBytes] (convert.js:84:1)
    at codec.js:97:1
    at Array.map (<anonymous>)
    at stringTuplesToTuples (codec.js:91:1)
    at stringToBytes (codec.js:183:1)
    at Object.fromString (codec.js:190:1)
    at __webpack_modules__../node_modules/multiaddr/src/index.js.withIs.proto.className (index.js:46:1)
    at new <anonymous> (index.js:40:1)

lidel · 2022-09-27T20:30:43Z

multiformats/js-multiaddr#271 was missing tests for /webtransport/certhash/../certhash/.. (addr format announced by Kubo 0.16.0-rc1)

I've added them in multiformats/js-multiaddr#276 but code from multiaddr@11 parses it correctly, so this looks like a problem on ipfs-webui's end (ancient dependencies).

Probably the only workaround here is reverse engineering the exception this and creating an ad-hoc patch against multiaddr@8.1.2 that does not throw when certhash is present.

BigLep · 2022-10-04T15:06:38Z

What's the verdict here? Are we going to do more hacks, or just this as more forcing function to get the dependencies updated... ?

SgtPooki · 2022-10-07T22:12:55Z

What's the verdict here? Are we going to do more hacks, or just this as more forcing function to get the dependencies updated... ?

@BigLep This is going to require dependency updates.. hacks aren't really going to work without those hacks bleeding into older dependency versions that don't require those hacks in the newest versions. It's most likely less work to update webui than try to figure out a working hack

BigLep · 2022-10-08T01:19:36Z

@SgtPooki : ACK. One more thing dependent on the dependency update project! Let's add it to the issue to put further weight on the criticality of that work. Thanks.

lidel · 2022-10-13T14:07:23Z

Just flagging this is a hard blocker for having WebTransport enabled by default in Kubo.

SgtPooki · 2022-10-25T17:12:08Z

@marten-seemann per our discussion, see #2033 (comment)

We can dive into this deeper at your convenience

SgtPooki · 2022-10-25T17:17:14Z

Just flagging this is a hard blocker for having WebTransport enabled by default in Kubo.

@lidel is this status text not being visible really worth blocking enabling webtransport by default?

Would adding a UI notification with link to a tracking issue for this problem(this issue) be sufficient to unblock kubo? I don't feel like blocking the ecosystem because UI rendering a text field is broken is worth the delay.

I'm open to being corrected.

Closes #2033

## [2.20.0](v2.19.0...v2.20.0) (2022-11-09) CID `bafybeibjbq3tmmy7wuihhhwvbladjsd3gx3kfjepxzkq6wylik6wc3whzy` --- ### Features * add success notification on "set pinning" action ([#2038](#2038)) ([e410164](e410164)) * track remote pins in progress ([#1919](#1919)) ([d3a6524](d3a6524)) * update to ipfs-geoip v9 ([#2061](#2061)) ([546fb5a](546fb5a)) ### Bug Fixes * /webtransport breaks status page ([#2057](#2057)) ([ea89e7f](ea89e7f)), closes [#2033](#2033) ### Trivial Changes * pull new translations ([#2049](#2049)) ([f6062b2](f6062b2)) * pull new translations ([#2056](#2056)) ([e13ff17](e13ff17)) * pull new translations ([#2059](#2059)) ([0bb5bf3](0bb5bf3))

ipfs-gui-bot · 2022-11-09T23:25:24Z

🎉 This issue has been resolved in version 2.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

lidel added need/triage Needs initial labeling and prioritization kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up labels Sep 27, 2022

SgtPooki self-assigned this Sep 27, 2022

SgtPooki mentioned this issue Sep 27, 2022

chore: Dependency updates #1965

Open

23 tasks

SgtPooki added a commit that referenced this issue Sep 27, 2022

chore: attempt to fix webtransport identity

fc939b7

see #2033

SgtPooki added the status/blocked Unable to be worked further until needs are met label Sep 29, 2022

lidel mentioned this issue Sep 30, 2022

Document how to connect browser nodes with Kubo nodes using WebTransport ipfs/ipfs-docs#1286

Closed

SgtPooki added topic/interop Interoperability P0 Critical: Tackled by core team ASAP and removed need/triage Needs initial labeling and prioritization P1 High: Likely tackled by core team if no one steps up labels Oct 10, 2022

lidel mentioned this issue Oct 21, 2022

Update Peers screen to use ipfs-geoip v9.0.0 #2055

Closed

2 tasks

SgtPooki linked a pull request Oct 26, 2022 that will close this issue

fix: /webtransport breaks status page #2057

Merged

whizzzkid added dependencies and removed status/blocked Unable to be worked further until needs are met labels Oct 31, 2022

SgtPooki mentioned this issue Nov 2, 2022

fix: /webtransport breaks status page #2057

Merged

lidel closed this as completed in #2057 Nov 7, 2022

lidel pushed a commit that referenced this issue Nov 7, 2022

fix: /webtransport breaks status page (#2057)

ea89e7f

Closes #2033

ipfs-gui-bot added the released label Nov 9, 2022

This was referenced Nov 9, 2022

feat: ipfs-webui 2.20.0 ipfs/kubo#9390

Merged

feat: ipfs-webui 2.20.0 ipfs/ipfs-desktop#2330

Closed

SgtPooki mentioned this issue Nov 29, 2022

IPFS Desktop and webui add WebTransport and DAG CAR support ipfs/ipfs-gui#109

Open

2 tasks

This was referenced Dec 9, 2022

fix: support /quic-v1 #2073

Merged

Don't fail on unknown codec / protocol ipfs/js-kubo-rpc-client#103

Open

This was referenced Feb 8, 2023

feat!: migrate to ESM #2092

Merged

bug: new kubo/ipfs/libp2p protocols break JS ecosystem multiformats/js-multiaddr#310

Open

lidel mentioned this issue Nov 9, 2023

/webrtc-direct listener breaks Status page #2176

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enabling WebTransport in Kubo v0.16.0-rc1 breaks Status page #2033

Enabling WebTransport in Kubo v0.16.0-rc1 breaks Status page #2033

lidel commented Sep 27, 2022 •

edited

Loading

SgtPooki commented Sep 27, 2022

SgtPooki commented Sep 27, 2022

SgtPooki commented Sep 27, 2022 •

edited

Loading

SgtPooki commented Sep 27, 2022 •

edited

Loading

SgtPooki commented Sep 27, 2022

lidel commented Sep 27, 2022 •

edited

Loading

BigLep commented Oct 4, 2022

SgtPooki commented Oct 7, 2022

BigLep commented Oct 8, 2022

lidel commented Oct 13, 2022 •

edited

Loading

SgtPooki commented Oct 25, 2022

SgtPooki commented Oct 25, 2022 •

edited

Loading

ipfs-gui-bot commented Nov 9, 2022

Enabling WebTransport in Kubo v0.16.0-rc1 breaks Status page #2033

Enabling WebTransport in Kubo v0.16.0-rc1 breaks Status page #2033

Comments

lidel commented Sep 27, 2022 • edited Loading

How to reproduce

Broken state

Suspected cause

SgtPooki commented Sep 27, 2022

SgtPooki commented Sep 27, 2022

SgtPooki commented Sep 27, 2022 • edited Loading

SgtPooki commented Sep 27, 2022 • edited Loading

SgtPooki commented Sep 27, 2022

lidel commented Sep 27, 2022 • edited Loading

BigLep commented Oct 4, 2022

SgtPooki commented Oct 7, 2022

BigLep commented Oct 8, 2022

lidel commented Oct 13, 2022 • edited Loading

SgtPooki commented Oct 25, 2022

SgtPooki commented Oct 25, 2022 • edited Loading

ipfs-gui-bot commented Nov 9, 2022

lidel commented Sep 27, 2022 •

edited

Loading

SgtPooki commented Sep 27, 2022 •

edited

Loading

SgtPooki commented Sep 27, 2022 •

edited

Loading

lidel commented Sep 27, 2022 •

edited

Loading

lidel commented Oct 13, 2022 •

edited

Loading

SgtPooki commented Oct 25, 2022 •

edited

Loading