feat: allow settings even when the daemon is offline #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
18 tasks
hacdias
force-pushed
the
feat/settings-offline
branch
from
8c70f9e
to
334e8f0
Compare
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
force-pushed
the
feat/settings-offline
branch
from
4acf696
to
1f9b1a2
Compare
|
I know I shouldn't force push, but I did :O Just trying to trigger the CI with the latest updates. For some reason the tests pass locally but weren't passing in the CI. |
|
@hacdias you should be able to re-trigger the build via the circle-ci web interface. let me know if that's not the case |
|
@olizilla it says I don't have write permissions, which is weird. I believe I could trigger builds before. It passes now though 😄 |
olizilla
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1019 by allowing the Settings page even when IPFS config is not available, or the daemon is offline. It might be useful because the settings page contains much more than IPFS own settings.
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com