fix: useless list re-renders #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
ghost
assigned 
fsdiogo
approved these changes
May 2, 2019
|
Thanks for spotting this and taking the time to fix it. Improvements like this help make the app more robust, which in turn will make people trust it more, and want to use it. I wonder how we might create tests for this kind of thing issue... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the useless tons of re-renders on file pages. It happened because every time we returned from
selectFiles, we were sorting at the time and using the spread operator, hence creating a new different object, causing a re-render. Now it just changes when the files are fetched and when the sorting is updated.Also, fixed the issue where you open the Web UI on files page and it just wouldn't load.
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com