Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup files page #1029

Merged
merged 12 commits into from
May 8, 2019
Merged

refactor: cleanup files page #1029

merged 12 commits into from
May 8, 2019

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented May 1, 2019 •
edited
Loading

This declutters the FilesPage file a lot.

  • Moves the modals to their own directory and the info boxes to their own directory too 5409447
  • Cleans up files.extra on preview c2055cc
  • Quickly fixes a message f8a3059
  • Cleans up context menu 63b4164
  • Moves header outside of files page ea6b761

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

@hacdias
refactor: some cleanup
5409447 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@ghost ghost assigned hacdias May 1, 2019
@ghost ghost added the status/in-progress In progress label May 1, 2019
@hacdias hacdias requested review from fsdiogo and olizilla and removed request for fsdiogo May 1, 2019 22:09
@hacdias hacdias changed the title refactor: some cleanup refactor: separate info-boxes and modals from FilesPage May 1, 2019
@hacdias hacdias changed the title refactor: separate info-boxes and modals from FilesPage refactor: separate infoand modals from FilesPage May 1, 2019
@hacdias hacdias changed the title refactor: separate infoand modals from FilesPage refactor: separate info and modals from FilesPage May 1, 2019
@hacdias
refactor: cleans up files.extra on preview
c2055cc 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
fix: button name
f8a3059 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias mentioned this pull request May 1, 2019
Merged
@hacdias hacdias changed the title refactor: separate info and modals from FilesPage refactor: cleanup files page May 1, 2019
@hacdias
refactor: only one ctx menu
63b4164 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
refactor: move header outside files page
ea6b761 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
fix: remove unused variable
6d1b472 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented May 1, 2019

@olizilla @fsdiogo for the best reviewing experience, I think it'd be better to go commit by commit as their subject-focused 😄

@olizilla
Copy link
Member

olizilla commented May 2, 2019

@hacdias the context menu modal doesn't close if you click off it, but does on master, can you take a look pls?

@hacdias
fix: hide context menu when navigation happens
98b6395 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
revert: previous commit
f896579 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
fix: unused dependency
f2d4018 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented May 2, 2019

@olizilla could you take a look at tableflip/react-dropdown#5 please?

@hacdias
fix: ctx menu position
c5cd4e4 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Merge branch 'master' into refactor/cleanup-a-bit
624db28
@hacdias
Copy link
Member Author

hacdias commented May 2, 2019

Thanks for the review @fsdiogo. Just waiting for the updated react-dropdown. /cc @olizilla 😄

@olizilla
Copy link
Member

olizilla commented May 3, 2019

thanks @hacdias ... @tableflip/react-dropdown@1.3.0 is now a thing

@hacdias
feat: update react-dropdown
a049e8e 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented May 3, 2019

@olizilla updated 😄

@hacdias
Copy link
Member Author

hacdias commented May 7, 2019

Ping @olizilla

olizilla
olizilla approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olizilla olizilla merged commit f26871f into master May 8, 2019
@olizilla olizilla deleted the refactor/cleanup-a-bit branch May 8, 2019 08:58
@ghost ghost removed the status/in-progress In progress label May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsdiogo fsdiogo fsdiogo left review comments

@olizilla olizilla olizilla approved these changes

Assignees

@hacdias hacdias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacdias @olizilla @fsdiogo