Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use electron dir picker on IPFS Desktop #1034

Merged
merged 8 commits into from
May 31, 2019

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented May 13, 2019

Required for ipfs/ipfs-desktop#927.

Simply adds a new parameter for doFilesWrite and uses IPFS Desktop handling directories.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@ghost ghost assigned hacdias May 13, 2019
@ghost ghost added the status/in-progress In progress label May 13, 2019
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias requested a review from olizilla May 13, 2019 17:19
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
src/lib/files.js Outdated Show resolved Hide resolved
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented May 15, 2019

Ping @olizilla

@olizilla
Copy link
Member

To dig ourselves out of this hole we need to write tests for

  • file-drop at root
    • 1 file
    • multiple files
    • multiple files and system files are filtered out
    • 1 directory
    • 1 directory and system files are filtered out
    • muliple directories (pretty sure dropping multiple dirs has never worked)
  • file-drop on folder
    • 1 file
    • multiple files
    • multiple files and system files are filtered out
    • 1 directory
    • 1 directory and system files are filtered out
    • muliple directories (pretty sure dropping multiple dirs has never worked)
  • file-input
    • 1 file
    • multiple files
    • multiple files and system files are filtered out
    • 1 directory
    • 1 directory and system files are filtered out

and have a way to run them in:

  • firefox
  • chrome
  • ipfs-desktop

I think in these PR as they are, filtering of system files wont happen if you add files via a file input in ipfs-desktop. But there are so many routes through that it's hard to say from just staring at the code.

src/bundles/files.js Outdated Show resolved Hide resolved
@olizilla
Copy link
Member

@hacdias can you update this PR now the other files fixes are in pls.

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented May 30, 2019

@olizilla done!

@hacdias
Copy link
Member Author

hacdias commented May 31, 2019

@olizilla can we get this merged?

@hacdias hacdias merged commit da9af02 into master May 31, 2019
@hacdias hacdias deleted the fix/use-electron-dir-picker branch May 31, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants