-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use electron dir picker on IPFS Desktop #1034
Conversation
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
Ping @olizilla |
To dig ourselves out of this hole we need to write tests for
and have a way to run them in:
I think in these PR as they are, filtering of system files wont happen if you add files via a file input in ipfs-desktop. But there are so many routes through that it's hard to say from just staring at the code. |
@hacdias can you update this PR now the other files fixes are in pls. |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
@olizilla done! |
@olizilla can we get this merged? |
Required for ipfs/ipfs-desktop#927.
Simply adds a new parameter for
doFilesWrite
and uses IPFS Desktop handling directories.License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com