Fix manifest.json content #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed app names and colors
hacdias
approved these changes
May 13, 2019
|
/cc @olizilla |
olizilla
reviewed
May 14, 2019
| @@ -10,6 +10,6 @@ | |||
| ], | |||
| "start_url": "./index.html", | |||
| "display": "standalone", | |||
| "theme_color": "#000000", | |||
| "background_color": "#ffffff" | |||
| "theme_color": "#0b3a53", | |||
There was a problem hiding this comment.
I'm not sure where these color values get used, but the defaults set them to black and white, so I'd guess we don't want to set both of these colors to be the same.
There was a problem hiding this comment.
More info:
- https://developers.google.com/web/fundamentals/web-app-manifest/#background-color
- https://developers.google.com/web/fundamentals/web-app-manifest/#theme-color
I think it's OK to keep the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed app names and colors