fix: drop multiple files on chrome

[hacdias]

Fixes #1045 by using my fork of datatransfer-files-promise. I didn't publish it because I was hoping the original creator would accept my PR, although @grabantot doesn't seem very active on GitHub.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

[hacdias]

@olizilla why I haven't done the tests for this: #1047 (comment)

[olizilla]

@hacdias 👍 you could publish it under your npm namespace like @hacdias/datatransfer-files-promise in the meantime.

[olizilla]

So it'd be rad to add tests for the datatransfer-files-promise...it's a function that takes an array-ish DataTransferItemList, where each entry may be a single file or a tree of files, and returns a flat array of objects with a filePath property, that encodes the path in the tree where it came from.

We'd need to do some mocking... each item in the input array needs a .webkit​GetAsEntry() function that returns an entry with either .isFile or .isDirectory set to true and and entry.name. Where we set .isFile to true, we expect to just see filePath in the output object set to entry.name. Where isDirectroy is true, we need to provide an entry.createReader function that returns an object with a .getEntries function that returns an array of entries... from which we can mock out a tree structure of entries.

It's a bit of work, but it'd be really nice.

[olizilla]

For example we should test what happens when a brower use getAsEntry instead of webkitGetAsEntry as per

This function is implemented as webkitGetAsEntry() in non-WebKit browsers including Firefox at this time; it may be renamed to simply getAsEntry() in the future, so you should code defensively, looking for both.

https://developer.mozilla.org/en-US/docs/Web/API/DataTransferItem/webkitGetAsEntry

[hacdias]

@olizilla yeah, thanks. I'm aware of the structure, I've already started them 😃

[hacdias]

@olizilla just released it as a package. The tests will go on #1047 here.

[hacdias]

@olizilla I'm hitting an infinite loop on the directory tests and I don't know why. I know the loop is happening on the module (datatransfer-files-promise, both with mine and the original version) but it must be something in the structure I'm creating that's causing it.

[hacdias]

@olizilla found the issue. Ready for review 😃

[olizilla]

Good stuff! Some minor tweaks to do.

More significantly, now that this code can handle the case where the user drops mutliple directories, i notice that I can't actually drop multiple directories in practice due to an error around the logic of counting how many directories we expect go-ipfs will make... can you take a look...

https://github.com/ipfs-shipyard/ipfs-webui/blob/master/src/lib/count-dirs.test.js#L32-L42

[hacdias]

@olizilla just updated the tests. One question about https://github.com/ipfs-shipyard/ipfs-webui/blob/master/src/lib/count-dirs.test.js#L32-L42. Why is it testing against 8? Is that the wrong part?

[olizilla]

@hacdias it assumes ipfs will make a dir for the root /, perhaps that assumption should change.

[olizilla]

see: https://github.com/ipfs-shipyard/ipfs-webui/blob/83fbf45156f78c5fd90bb502e600d7f127c32749/src/lib/count-dirs.test.js#L4-L6

[olizilla]

@hacdias does that make sense?

[hacdias]

@olizilla yes, it does. Could we merge this PR and I'll take a look at count-dirs on another one?