Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add sorting to peers table #1068

Merged
merged 1 commit into from
Jul 23, 2019
Merged

chore: add sorting to peers table #1068

merged 1 commit into from
Jul 23, 2019

Conversation

JustMaier
Copy link
Contributor

Rebased for master.

Sorting in peer table with default sorting based on latency column

Copy link
Contributor

@fsdiogo fsdiogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JustMaier, this looks great! 👌

Please run npm run lint and fix the linting erros that will cause the CI to fail when merging this!

@fsdiogo fsdiogo added help wanted Seeking public contribution on this issue status/in-progress In progress P1 High: Likely tackled by core team if no one steps up labels Jul 18, 2019
@JustMaier
Copy link
Contributor Author

@fsdiogo oops. Thanks for catching that. Fixed and pushed.

Copy link
Contributor

@fsdiogo fsdiogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fsdiogo fsdiogo requested a review from olizilla July 19, 2019 09:22
@olizilla
Copy link
Member

Thank you @JustMaier!

@olizilla olizilla merged commit fb9718d into ipfs:master Jul 23, 2019
@olizilla olizilla mentioned this pull request Jul 23, 2019
8 tasks
@JustMaier
Copy link
Contributor Author

Yay! Happy to have been able to contribute a little something to the cause :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/in-progress In progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants