fix: stop crashing pin screen on a single ipfs.files.stat error #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes pin listing more robust by never throwing errors returned by ipfs.files.stat for individual pins. We just mark those items as 'unknown' and continue. That way user is able to list all pins, and if they click on 'unknown' item that produces an error, the error will be displayed in IPLD Explorer (Inspector).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes pin listing more robust by never throwing errors returned by
ipfs.files.statfor individual pins. Fixes #1095 for all repos.Motivation
Error handling introduced in #1115 was bit naive and when anything other than 'non unixfs' error was detected, it was re-thrown. This broke rendering of pin list on my end:
My repo has some bizzare DAGs, which provided good sandbox for testing shortcomings of old error handling:
Changes
We just mark non-unixfs or errored items as 'unknown' and continue.
That way user is able to list all pins, and if they click on an 'unknown' item that produces an error, it will be displayed in IPLD Explorer (Inspector), so no information is lost.