feat: improve nav bar #1128
Merged
feat: improve nav bar #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
lidel
requested changes
Aug 26, 2019
There was a problem hiding this comment.
Mixed feelings:
What if we hide decimal when unit is MB and KB (low value, adds noise),
but show it for size bigger than 1 GB? At that point decimal becomes meaningful.
You should be able to do that inside of humanSize by checking the size on the fly and enabling/hiding decimal.
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
|
@lidel done:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies #1122!
Is it better with one or zero decimals?
I believe that using 0 decimals can hide a bit the difference between repo and the files sizing...
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com