Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight everything but protocols #1188

Merged
merged 2 commits into from
Sep 20, 2019

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Sep 19, 2019

I also added ipfs to the list of protocols to make sure we don't highlight it.

image

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 lgtm with a small note about future-proofing below

src/components/address/Address.js Outdated Show resolved Hide resolved
Co-Authored-By: Marcin Rataj <lidel@lidel.org>
@hacdias hacdias merged commit d4af67e into master Sep 20, 2019
@hacdias hacdias deleted the feat/highlight-everything-but-protos branch September 20, 2019 07:41
@hacdias hacdias mentioned this pull request Sep 23, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants